Remove cStringIO usage

[tiran]

BPO	1770008
Nosy	@gvanrossum, @birkenfeld, @tiran, @avassalotti
Files	remove_stringio.patch: py3k-struni r56829

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/gvanrossum'
closed_at = <Date 2008-01-06.22:29:45.731>
created_at = <Date 2007-08-08.12:42:58.000>
labels = ['library']
title = 'Remove cStringIO usage'
updated_at = <Date 2008-01-06.22:29:45.731>
user = 'https://github.com/tiran'

bugs.python.org fields:

activity = <Date 2008-01-06.22:29:45.731>
actor = 'admin'
assignee = 'gvanrossum'
closed = True
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2007-08-08.12:42:58.000>
creator = 'christian.heimes'
dependencies = []
files = ['8160']
hgrepos = []
issue_num = 1770008
keywords = ['patch']
message_count = 9.0
messages = ['53003', '53004', '53005', '53006', '53007', '53008', '53009', '53010', '53011']
nosy_count = 4.0
nosy_names = ['gvanrossum', 'georg.brandl', 'christian.heimes', 'alexandre.vassalotti']
pr_nums = []
priority = 'normal'
resolution = 'accepted'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue1770008'
versions = ['Python 3.0']

[tiran]

The patch removes the import of cStringIO from all Python files and disabled the cStringIO module. It leaves the file around.

Open problems:

• How should io.StringIO handle buffer objects?

[tiran]

File Added: stringio_deprecation.patch

[birkenfeld]

I guess that if you want to handle buffer objects, you should be using io.BytesIO.

[tiran]

The new patch also removes StringIO and adds a facade cStringIO. Importing StringIO and cStringIO is deprecated and the imports fall back to io.StringIO.
File Added: remove_stringio.patch

[gvanrossum]

I'll take this. Thanks for the work! There are a few tests that break due to this, I'll look into these. I'll probably kill StringIO and cStringIO hard rather than adding deprecations (there's already a 2to3 fixer that fixes most StringIO references).

[gvanrossum]

Thanks!

Committed revision 56841.

I had to change some places to use BytesIO instead of StringIO, and I had to work hard on a few modules, esp. uu.py. But now all tests pass (except the ones that didn't pass before).

[avassalotti]

As George said, io.BytesIO should be used for buffer objects.

Thanks for your work, it will help me a lot for testing the new accelerator module for StringIO/BytesIO.

[tiran]

One unit test is still import StringIO although it doesn't use it:

Index: Lib/ctypes/test/test_loading.py
===================================================================

--- Lib/ctypes/test/test_loading.py     (Revision 56879)
+++ Lib/ctypes/test/test_loading.py     (Arbeitskopie)
@@ -1,6 +1,6 @@
 from ctypes import *
 import sys, unittest
-import os, StringIO
+import os
 from ctypes.util import find_library
 from ctypes.test import is_resource_enabled

[gvanrossum]

Ow, thanks!

Committed revision 56880.