urllib* 20x responses not OK?

[jimjjewett]

BPO	1177
Nosy	@birkenfeld, @facundobatista, @kbkaiser
Files	urllib26min2xx.txt

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/kbkaiser'
closed_at = <Date 2008-01-02.04:13:55.350>
created_at = <Date 2007-09-18.20:22:53.840>
labels = ['type-bug', 'library']
title = 'urllib* 20x responses not OK?'
updated_at = <Date 2008-01-02.04:13:55.348>
user = 'https://bugs.python.org/jimjjewett'

bugs.python.org fields:

activity = <Date 2008-01-02.04:13:55.348>
actor = 'kbk'
assignee = 'kbk'
closed = True
closed_date = <Date 2008-01-02.04:13:55.350>
closer = 'kbk'
components = ['Library (Lib)']
creation = <Date 2007-09-18.20:22:53.840>
creator = 'jimjjewett'
dependencies = []
files = ['8462']
hgrepos = []
issue_num = 1177
keywords = ['patch']
message_count = 12.0
messages = ['56009', '56011', '56014', '56016', '56030', '56031', '56033', '56037', '56113', '56121', '59086', '59087']
nosy_count = 5.0
nosy_names = ['georg.brandl', 'facundobatista', 'kbk', 'jafo', 'jimjjewett']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue1177'
versions = ['Python 2.6']

[jimjjewett]

Under the http protocol, any 2xx response is OK.

urllib.py and urllib2.py hardcoded only response 200 (the most common).

http://bugs.python.org/issue912845 added 206 as acceptable to urllib2, but
not any other 20x responses. (It also didn't fix urllib.)

Suggested for 2.6, as it does change behavior.

(Also see duplicate http://bugs.python.org/issue971965 which I will try to
close after opening this. )

[facundobatista]

It should behave as you say, yes.

I fixed the class HTTPErrorProcessor(BaseHandler) regarding this issue,
to not raise an error if response is 2xx (see rev 54927).

Regards,

[jafo]

Facundo: Should this be closed?

[jimjjewett]

Jafo: His fix is great for urllib2, but the same issue applies to the
original urllib.

The ticket should not be closed until a similar fix is made to lines 330 and
417 of urllib.py.

That is, change

"if errcode == 200:" to "if 200 <= errcode < 300:"

(Or, if rejecting the change, add a comment saying that it is left that way
intentionally for backwards compatibility.)

-jJ

[jafo]

Ported code change to urllib, passes tests, committed as revision 58206

[birkenfeld]

This might need at least a NEWS entry, if not a documentation clarification.

[jafo]

Facundo, can you do a NEWS update on this?

[facundobatista]

Done, rev 58207.

[jimjjewett]

The change still missed
the httpS copy. I'm
attaching a minimal change.

I think it might be better
to just combine the
methods -- as was already
done in Py3K.
Unfortunately, the py3K
code doesn't run cleanly
in 2.5, and I haven't yet
had a chance to test a
backported equivalent.
(Hopefully tonight.)