trunk version does not compile with vs8 and vc6

[amauryfa]

BPO	2065
Nosy	@loewis, @amauryfa, @tiran
Files	issue2065.patch: correct compilation on vc6 + vs8 ocean.zip: use winsock2 in trunk/py3k ocean.zip: "MODULE_NAME="sqlite3"" ocean.zip ocean-remaining.zip ocean-remaining.zip: Added _multiprocessing support

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/amauryfa'
closed_at = <Date 2008-08-14.08:32:08.552>
created_at = <Date 2008-02-11.10:50:13.853>
labels = ['OS-windows']
title = 'trunk version does not compile with vs8 and vc6'
updated_at = <Date 2008-08-14.08:32:08.536>
user = 'https://github.com/amauryfa'

bugs.python.org fields:

activity = <Date 2008-08-14.08:32:08.536>
actor = 'loewis'
assignee = 'amaury.forgeotdarc'
closed = True
closed_date = <Date 2008-08-14.08:32:08.552>
closer = 'loewis'
components = ['Windows']
creation = <Date 2008-02-11.10:50:13.853>
creator = 'amaury.forgeotdarc'
dependencies = []
files = ['9409', '9873', '9946', '10574', '10618', '11065']
hgrepos = []
issue_num = 2065
keywords = ['patch']
message_count = 22.0
messages = ['62276', '62287', '62328', '62336', '62341', '62344', '62350', '62353', '62357', '62517', '63219', '64967', '65016', '67982', '68112', '68113', '68116', '68155', '68158', '71103', '71113', '71114']
nosy_count = 4.0
nosy_names = ['loewis', 'amaury.forgeotdarc', 'ocean-city', 'christian.heimes']
pr_nums = []
priority = 'high'
resolution = 'accepted'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue2065'
versions = ['Python 2.6']

[amauryfa]

Since r60696, WINVER is forced to _WIN32_WINNT_WIN2K. This has two problems:

• Vs8 (and before) does not define _WIN32_WINNT_WIN2K. It should be
  replaced with 0x500.
• When WINVER is set to 0x500, vc6 gives a long warning because at the
  time, windows nt 5.0 was only at beta stage. Moreover, there are other
  clashes between winsock.h and winsock2.h, that show up when WINVER is 0x500.

To correct this, I propose:

• To replace _WIN32_WINNT_WIN2K and similar constants by their values.
• That 0x500 is not the required value, but the *maximum* value
  necessary when targeting win2k. VC6 can set it to 0x400.

I'll try a patch later tonight.

[amauryfa]

Attached a patch to compile trunk with vc6 and vs8.
Most tests pass with these two compilers.

Tests needed for vs7 and vs9!

[loewis]

Ithink this patch still conflicts with bpo-1763 - SHGetFolderPathW is
(apparently) only available on W2k. So I don't see why we *shouldn't*
mandate W2k-or-better platform headers. VC6 users should install the W2k
SDK, or the W2k3 SDK (or any later SDK that still supports VC6).

[amauryfa]

Is it permitted to allow python compile with older compilers, even with
some functions missing?

This patch already skips some functions not included with VC6:
socket.ioctl, msvcrt.getwch &co.
Even socket.RCVALL_IPLEVEL is not available on my installation of VS8
(Professional Edition).

Even if the result is only a subset of the official python (as shown
when running the test suite), it may still be useful, when embedded in
legacy applications for example, where installing a new SDK is not
always possible.

[loewis]

Is it permitted to allow python compile with older compilers, even with
some functions missing?

It's certainly ok that Python may not have some functions on "some
system". Even though there might not be any precedence, I think this
extends to "some compilers on the same system".

[tiran]

Amaury Forgeot d'Arc wrote:

Is it permitted to allow python compile with older compilers, even with
some functions missing?

When a user compiles her own Python binary she is most probably
experienced enough to notice the difference. We can't hold the hand of
every user who strolls off the official path. New features was one of
reasons for the migration to VS 2008. Legacy support shouldn't stop us
from introducing new features.

So yes, it's permitted to build Python with old compilers but users must
not expect full support of all features.

Christian

[ocean-city]

I tried PSDK Feb 2003 downloadable from
http://www.microsoft.com/msdownload/platformsdk/sdkupdate/psdk-full.htm
and this two issues went away.

• When WINVER is set to 0x500, vc6 gives a long warning because at the
  time, windows nt 5.0 was only at beta stage. Moreover, there are other
  clashes between winsock.h and winsock2.h, that show up when WINVER is
  0x500.

Next, I tried to compile Modules/socketmodule.h's _MSC_VER >= 1300 part
but this didn't work.

#if _MSC_VER >= 1300
# include <winsock2.h>
# include <ws2tcpip.h>
# include <MSTcpIP.h> /* for SIO_RCVALL */
# define HAVE_ADDRINFO
# define HAVE_SOCKADDR_STORAGE
# define HAVE_GETADDRINFO
# define HAVE_GETNAMEINFO
# define ENABLE_IPV6
#else
# include <winsock.h>
#endif

I didn't investigate too much, but it seems
#include <windows.h>
#include <winsock2.h>
causes another conflicts between winsock.h and winsock2.h
this time.

[amauryfa]

Next, I tried to compile Modules/socketmodule.h's _MSC_VER >= 1300
part but this didn't work.

Which compiler are you using? And which errors did you get?

[ocean-city]

Which compiler are you using? And which errors did you get?

VC6 + PSDK2003Feb. The error was same to
http://svn.haxx.se/users/archive-2006-10/0557.shtml

E:\Microsoft\PSDK\Include\ws2tcpip.h(593) : error C2632: 'int'
followed by 'int' is illegal

causes another conflicts between winsock.h and winsock2.h
this time.

This was not true. This error happened because pyconfig.h defines
socklen_t to int on VC6. I could fix this and build python with VC6 +
winsock2. Probably this is way to go. (Attached patch as ocean.zip)

regrtest.py passed other than test_float (this is because VC6 doesn't
support NaN comparation, I don't care)

# I'm still missing my 500MB disk space occupied by PSDK2003Feb though ;-)

[ocean-city]

Follow up r60882.

[ocean-city]

Failed to compile py3k again, created patch for
three branches. You can close bpo-1720 and bpo-1700463
because they are duplicated issues.

# I merged Amaury's patch, I hope this patch also
# works for VS8.

[ocean-city]

I don't know why, but
/D "MODULE_NAME=\"sqlite3\""
is troublesome. VC6 IDE expands this to
#define MODULE_NAME " sqlite3".

To workaround this, I used
/D MODULE_NAME=\"sqlite3\"
instead in sqlite3.dsp.

[ocean-city]

_wstat64 does not exist in VC6, so used GetFileAttributesW instead.

[amauryfa]

First, thank you for keeping these patches up to date.

- The patch for 2.5 is OK for me. We could just add the a paragraph that
appears in your patch for trunk (PC/VC6/readme.txt):
+_msi
+    _msi.c. You need to install Windows Installer SDK to build this module.

• I worked on your patch for trunk/ and py3k/ to allow compilation with
  a stock VC6 *without* a modern PlatformSDK installed (i.e NTDDI_VERSION
  is not defined)
  This is relevant only for socketmodule; with a stock VC6, IPV6 is not
  available, WSAIoctl is not exposed, and getaddrinfo() is emulated.

• Replacing _wstat with GetFileAttributesW is good thing: stat("nul")
  says that the file exists!
  But it is not enough: try to "import con" or "import nul", before and
  after your patch. Fun in both cases (if you "import con", type some
  chars, and press ^Z)

• The patches also work for VS8.0 (I just had to update the list of .c)

I will try to come with updated files, and test them with VS2003 Express
(VS7.1).