tkSimpleDialog Window Flashing

[Longorh]

BPO	2638
Files	tkSimpleDialog.py issue_2638.diff

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2009-03-07.02:19:22.431>
created_at = <Date 2008-04-15.15:44:12.257>
labels = ['expert-tkinter']
title = 'tkSimpleDialog Window Flashing'
updated_at = <Date 2009-03-07.02:19:22.429>
user = 'https://bugs.python.org/Longorh'

bugs.python.org fields:

activity = <Date 2009-03-07.02:19:22.429>
actor = 'gpolo'
assignee = 'none'
closed = True
closed_date = <Date 2009-03-07.02:19:22.431>
closer = 'gpolo'
components = ['Tkinter']
creation = <Date 2008-04-15.15:44:12.257>
creator = 'Longorh'
dependencies = []
files = ['10035', '10931']
hgrepos = []
issue_num = 2638
keywords = ['patch']
message_count = 7.0
messages = ['65519', '65525', '69874', '69920', '69961', '78640', '83270']
nosy_count = 3.0
nosy_names = ['gpolo', 'Longorh', 'ronLongo']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue2638'
versions = ['Python 3.1', 'Python 2.7']

[Longorh]

When a Tkinter window comes up that uses tkSimpleDialog to construct a
dialog box, the window first flashes on the screen as an unpopulated
top-level window, before being drawn in its completed state.

This problem is easily corrected by adding two lines of code to the
constructor for class Dialog in tkSimpleDialog.py. The first line of
the constructor reads Toplevel.__init__( self, parent ). After this
line insert self.overrideredirect( True ). The second line from the
last in this constructor reads self.initial_focus.focus_set(), just
before this line insert self.overrideredirect( False). That's it.
I've attached the revised version of this file.

[gpolo]

Isn't overrideredirect only used to enable/disable borders in the window
? Why doing this fix what you described ?
Also, make a patch against python-trunk instead of sending the entire file.

[ronLongo]

Correct. overrideredirect only enables/disables borders. However,
what appears as a "flash" when the dialog box first appears is actually
a window with only borders being drawn (no contents). Disabling
borders BEFORE drawing anything prevents this "flash". I cannot say if
this "flash" occurs on all platforms, but it does occur on all windows
XP platforms that I've tried it on. In each of these cases the "fixed"
tkSimpleDialog.py prevents this "flash". While not vital to
application reliability, this fix does make applications appear more
professional.

[gpolo]

It would be more appropriate to properly use withdraw and deiconify
then. I'm attaching a patch that uses them.

[ronLongo]

Excellent! That solution works as well.

[gpolo]

Dropped for inclusion in python 2.5, but should still be considered for
trunk and py3k.

[gpolo]

Fixed in r70223 and r70225.

Thanks for reporting.