dummy_thread LockType.acquire() always returns None, should be True or False

[toymachine]

BPO	3339
Nosy	@brettcannon
Files	issue3339.diff

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/brettcannon'
closed_at = <Date 2008-07-13.01:21:45.297>
created_at = <Date 2008-07-11.07:52:34.251>
labels = ['type-bug', 'library']
title = 'dummy_thread LockType.acquire() always returns None, should be True or False'
updated_at = <Date 2008-07-13.01:22:01.409>
user = 'https://bugs.python.org/toymachine'

bugs.python.org fields:

activity = <Date 2008-07-13.01:22:01.409>
actor = 'brett.cannon'
assignee = 'brett.cannon'
closed = True
closed_date = <Date 2008-07-13.01:21:45.297>
closer = 'brett.cannon'
components = ['Library (Lib)']
creation = <Date 2008-07-11.07:52:34.251>
creator = 'toymachine'
dependencies = []
files = ['10875']
hgrepos = []
issue_num = 3339
keywords = ['patch']
message_count = 3.0
messages = ['69539', '69540', '69605']
nosy_count = 3.0
nosy_names = ['brett.cannon', 'mishok13', 'toymachine']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue3339'
versions = ['Python 2.5']

[toymachine]

Class LockType always seems to be returning None if waitflag is not
specified.

If you look up the documentation for the non dummy lock in lib ref
15.3.1 , none of the possible
results should be ‘None’, in fact it would always return True, except
when non-block is specified
And another thread is already holding the lock then it would return False

From the docs on acquire():

Acquire a lock, blocking or non-blocking.
When invoked without arguments, block until the lock is unlocked, then
set it to locked, and return true.
When invoked with the blocking argument set to true, do the same thing
as when called without arguments, and return true.
When invoked with the blocking argument set to false, do not block. If a
call without an argument would block, return false immediately;
otherwise, do the same thing as when called without arguments, and
return true.

[mishok13]

Seems like inconsistency to me, this simple patch should fix it.

[brettcannon]

r64903-64905 have the fixes for trunk, 3.0, and 2.5, respectively.
Thanks for reporting this, Henk. Andrii, I never even looked at your
patch since while I was evaluating the bug the problem was rather
obvious and simple, as you said. =) Thanks for the work, though.