IDLE hangs when passing invalid command line args (directory(ies) instead of file(s))

[gpolo]

BPO	3573
Nosy	@terryjreedy, @serwy, @merwok, @asvetlov
Files	fix_idle_startup_hang.diff

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/asvetlov'
closed_at = <Date 2012-03-20.21:06:26.593>
created_at = <Date 2008-08-16.23:32:25.454>
labels = ['expert-IDLE', 'type-bug', 'library']
title = 'IDLE hangs when passing invalid command line args (directory(ies) instead of file(s))'
updated_at = <Date 2012-03-21.23:27:41.000>
user = 'https://bugs.python.org/gpolo'

bugs.python.org fields:

activity = <Date 2012-03-21.23:27:41.000>
actor = 'eric.araujo'
assignee = 'asvetlov'
closed = True
closed_date = <Date 2012-03-20.21:06:26.593>
closer = 'asvetlov'
components = ['IDLE', 'Library (Lib)']
creation = <Date 2008-08-16.23:32:25.454>
creator = 'gpolo'
dependencies = []
files = ['11129']
hgrepos = []
issue_num = 3573
keywords = ['patch', 'needs review']
message_count = 13.0
messages = ['71249', '89022', '110682', '148593', '156464', '156465', '156488', '156489', '156490', '156496', '156497', '156523', '156524']
nosy_count = 7.0
nosy_names = ['terry.reedy', 'gpolo', 'roger.serwy', 'eric.araujo', 'asvetlov', 'BreamoreBoy', 'python-dev']
pr_nums = []
priority = 'high'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue3573'
versions = ['Python 2.7', 'Python 3.2', 'Python 3.3']

[gpolo]

Passing a single directory as a command line argument can make IDLE hang.
To achieve this the user needs to configure IDLE to open an editor
window by default.

The attached patch discards filenames that failed to load, so in the end
it may open an empty editor window instead of hanging.

[gpolo]

Idle has changed a bit since the initial message, so it no longer hangs
when it is configured to open an edit window by default, but now it
hangs when running it as: idle -e <somedirnamehere> (which the patch fixes).

[BreamoreBoy]

Please refer to msg89022.

[serwy]

I can confirm that using "idle -e <dir>" still causes a hang on Windows using 3.2.2 and on Ubuntu using 2.7.1 and 3.2

The given patch fixes the problem on those platforms.

[python-dev]

New changeset 01404295138d by Andrew Svetlov in branch 'default':
bpo-3573: idle now doesn't hungs if launched as: idle -e <directory>
http://hg.python.org/cpython/rev/01404295138d

[asvetlov]

Fixed. Thanks to Guilherme Polo and Roger Serwy.

[python-dev]

New changeset a95b19b3b4cd by Andrew Svetlov in branch '3.2':
bpo-3573: idle now doesn't hungs if launched as: idle -e <directory>
http://hg.python.org/cpython/rev/a95b19b3b4cd

New changeset cdcd1f7f0882 by Andrew Svetlov in branch 'default':
Merge from 3.2 for issue bpo-3573, fix Misc/NEWS as Ned Deily guess.
http://hg.python.org/cpython/rev/cdcd1f7f0882

[python-dev]

New changeset a9be863e5734 by Andrew Svetlov in branch '2.7':
bpo-3573: idle now doesn't hungs if launched as: idle -e <directory>
http://hg.python.org/cpython/rev/a9be863e5734

[asvetlov]

Backported to 3.2 and 2.7

[terryjreedy]

Thanks for applying.
Just note that unlike with svn, with hg it is stronly recommended to apply to 3.2 first and forward port to 3.3. Something about the DAGs working better.