Add some missing basic types in ctypes.wintypes

[ocean-city]

BPO	3612
Nosy	@theller
Files	add_some_missing_types.patch: done adds_LPDWORD_and_friends.patch: fancy avoid_giant_all.patch avoid_giant_all_and_add_LPs.patch avoid_giant_all_v2.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2010-09-28.21:10:59.169>
created_at = <Date 2008-08-20.05:03:51.534>
labels = ['ctypes']
title = 'Add some missing basic types in ctypes.wintypes'
updated_at = <Date 2010-09-28.21:10:59.167>
user = 'https://bugs.python.org/ocean-city'

bugs.python.org fields:

activity = <Date 2010-09-28.21:10:59.167>
actor = 'ocean-city'
assignee = 'ocean-city'
closed = True
closed_date = <Date 2010-09-28.21:10:59.169>
closer = 'ocean-city'
components = ['ctypes']
creation = <Date 2008-08-20.05:03:51.534>
creator = 'ocean-city'
dependencies = []
files = ['11169', '11176', '11178', '11179', '11183']
hgrepos = []
issue_num = 3612
keywords = ['patch']
message_count = 9.0
messages = ['71511', '71534', '71539', '71547', '71565', '71571', '71572', '71600', '117548']
nosy_count = 2.0
nosy_names = ['theller', 'ocean-city']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue3612'
versions = ['Python 3.2']

[ocean-city]

This patch adds some basic mssing types in ctypes.wintypes.
I think pointer type like LPDWORD would be usuful too, but maybe you
cannot ignore the overhead of POINTER object creation.

[theller]

I have no objections against this patch - feel free to check it in if it
is not too late before the beta.

Also I think that LPDWORD and friends are a good idea, you should extend
the patch with them.

[ocean-city]

I've committed basic type addition in r65908. Addition of LPDWORD and
its friends will follow.

[ocean-city]

I've created the patch which adds LPDWORD and friends.
Can you review it?

[theller]

I think this is too fancy. I would prefer to spell the definitions out
like this:

  LPDWORD = PDWORD = POINTER(DWORD)
  LPCSTR = LPSTR = c_wchar_p

We could avoid the giant __all__ list when we 'import ctypes as _ctypes'
and write (for example):

  DWORD = _ctypes.c_ulong

[ocean-city]

We could avoid the giant __all__ list when we 'import ctypes as >_ctypes'

How about the attached patch "avoid_giant_all.patch"?

[ocean-city]

And "avoid_giant_all_and_add_LPs.patch" adds bunch of LP(C)s.
I'm not sure all LP types are needed. (Especially handle types)

[ocean-city]

Module will be deleted at the end of file anyway (delete _ctypes), maybe
we could just do "import ctypes" and "delete ctypes".

[ocean-city]

Sorry for too late. I've committed in r85073(py3k).