tkColorChooser may fail if no color is selected

[gpolo]

BPO	3767
Nosy	@loewis
Files	str_result.diff tkColorChooser.diff

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/loewis'
closed_at = <Date 2008-12-29.16:28:46.232>
created_at = <Date 2008-09-03.22:32:10.522>
labels = ['expert-tkinter', 'release-blocker']
title = 'tkColorChooser may fail if no color is selected'
updated_at = <Date 2008-12-29.16:28:46.231>
user = 'https://bugs.python.org/gpolo'

bugs.python.org fields:

activity = <Date 2008-12-29.16:28:46.231>
actor = 'loewis'
assignee = 'loewis'
closed = True
closed_date = <Date 2008-12-29.16:28:46.232>
closer = 'loewis'
components = ['Tkinter']
creation = <Date 2008-09-03.22:32:10.522>
creator = 'gpolo'
dependencies = []
files = ['11364', '12043']
hgrepos = []
issue_num = 3767
keywords = ['patch']
message_count = 4.0
messages = ['72425', '76007', '77745', '78462']
nosy_count = 2.0
nosy_names = ['loewis', 'gpolo']
pr_nums = []
priority = 'release blocker'
resolution = 'accepted'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue3767'
versions = ['Python 2.6', 'Python 3.0', 'Python 2.7']

[gpolo]

Chooser._fixresult in the tkColorChooser module uses "if not result" to
check if user canceled the dialog, but nowadays Tk may return a cached
object that contains the result we are after, so, this object will not
simply evaluate to false and _fixresult will act like if the user didn't
cancel the dialog.
The fix is simple, just get the real value of result in that check.

[gpolo]

I've noticed a problem with the previous patch, so this new one includes
a comment too so people can remember about the check being applied.

[loewis]

Thanks for the patch.

Committed tkColorChooser.diff as r67738 in the 2.5 branch. Applying this
to the other branches still needs to be done.

[loewis]

Committed into various branches as r68010, r68011, r68012, and r68013