smtpd.py __getaddr insufficient handling

[marcusinternetnowaspnet]

BPO	3802
Nosy	@warsaw, @akheron

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2018-01-10.00:56:50.824>
created_at = <Date 2008-09-08.04:59:56.130>
labels = ['type-bug']
title = 'smtpd.py __getaddr insufficient handling'
updated_at = <Date 2018-01-10.00:56:50.822>
user = 'https://bugs.python.org/marcusinternetnowaspnet'

bugs.python.org fields:

activity = <Date 2018-01-10.00:56:50.822>
actor = 'barry'
assignee = 'none'
closed = True
closed_date = <Date 2018-01-10.00:56:50.824>
closer = 'barry'
components = []
creation = <Date 2008-09-08.04:59:56.130>
creator = 'marcus@internetnowasp.net'
dependencies = []
files = []
hgrepos = []
issue_num = 3802
keywords = ['patch']
message_count = 4.0
messages = ['72763', '109304', '146013', '309756']
nosy_count = 4.0
nosy_names = ['barry', 'marcus@internetnowasp.net', 'petri.lehtinen', 'lpolzer']
pr_nums = []
priority = 'normal'
resolution = 'wont fix'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue3802'
versions = ['Python 2.7', 'Python 3.2', 'Python 3.3']

[marcusinternetnowaspnet]

The __getaddr does not handle certain valid MAIL FROM well :

For eg,

<marcus@internetnow.com.my> SIZE=7777 AUTH=<>

would result in a mismatch of bracket handling.

Suggested fix is :-

def __getaddr(self, keyword, arg):
        address = None
        keylen = len(keyword)
        if arg[:keylen].upper() == keyword:
            address = arg[keylen:].strip()
            if not address:
                pass
            
            # Marcus fix :
            i  = address.count("<")
            ii = address.count(">")            
            if i != ii :
                address = None
                return address
            
            # Marcus remark : bug if : <abc@ap.com.my> SIZE=6092 AUTH=<>
            elif address[0] == '<' and address[-1] == '>' and address !
= '<>':
                # Addresses can be in the form <person@dom.com> but 
watch out
                # for null address, e.g. <>
                                
                if address.count("<") == 1 :
                    address = address[1:-1]
                    
        return address

[BreamoreBoy]

Note there is a patch inline, not sure if a doc patch is needed for this.

[akheron]

AFAIK, the extra MAIL FROM and RCPT TO parameters are only valid for ESMTP. smtpd doesn't currently handle ESMTP, so this should not be a problem.

[warsaw]

I'm closing this as won't fix since smtpd.py is deprecated and will likely not get any future development. Please see aiosmtpd as a much better third party replacement.