2to3 strips trailing L for long iterals in two fixers

[mitsuhiko]

BPO	4590
Nosy	@benjaminp, @mitsuhiko
Files	remove_redundant.diff

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/mitsuhiko'
closed_at = <Date 2008-12-09.06:54:50.081>
created_at = <Date 2008-12-08.11:09:16.489>
labels = ['type-bug', 'expert-2to3']
title = '2to3 strips trailing L for long iterals in two fixers'
updated_at = <Date 2013-01-28.23:30:10.053>
user = 'https://github.com/mitsuhiko'

bugs.python.org fields:

activity = <Date 2013-01-28.23:30:10.053>
actor = 'python-dev'
assignee = 'aronacher'
closed = True
closed_date = <Date 2008-12-09.06:54:50.081>
closer = 'aronacher'
components = ['2to3 (2.x to 3.x conversion tool)']
creation = <Date 2008-12-08.11:09:16.489>
creator = 'aronacher'
dependencies = []
files = ['12277']
hgrepos = []
issue_num = 4590
keywords = ['patch', 'needs review']
message_count = 5.0
messages = ['77296', '77389', '77390', '180873', '180888']
nosy_count = 4.0
nosy_names = ['benjamin.peterson', 'aronacher', 'python-dev', 'fabiomcosta']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue4590'
versions = ['Python 2.7']

[mitsuhiko]

I noticed that fix_long and fix_numliterals both strip trailing Ls from
numbers. That's redudant, one of them should be enough.

I attached a patch that removes the literal changing from the fix_long
fixer. Because I'm not sure if that may be the correct fixer to modify
I didn't commit it but created an issue for review.

[benjaminp]

I think this is the correct thing to do. Go ahead. (Did you see if any
of the long tests would be applicable in testing numliterals?)

[mitsuhiko]

Patch applied in [67679].

The tests were nearly the same, even with the same numbers :)

[fabiomcosta]

I believe that since this change the 2to3 documentation is outdated.

http://docs.python.org/2/library/2to3.html#2to3fixer-long
http://docs.python.org/2/library/2to3.html#2to3fixer-numliterals
http://docs.python.org/3/library/2to3.html#2to3fixer-long
http://docs.python.org/3/library/2to3.html#2to3fixer-numliterals

They could be updated to something like this:

long
Renames long to int. Check numliterals if you want to strip the L suffix on long literals.

numliterals
Converts octal and long literals into the new syntax.

Sorry if this is not the right channel to send documentation bug reports.

[python-dev]

New changeset d5ee6d13af18 by Benjamin Peterson in branch '3.3':
fix long fixer docs (bpo-4590)
http://hg.python.org/cpython/rev/d5ee6d13af18

New changeset 8b9910d8d27f by Benjamin Peterson in branch 'default':
merge 3.3 (bpo-4590)
http://hg.python.org/cpython/rev/8b9910d8d27f

New changeset 6904e229833d by Benjamin Peterson in branch '2.7':
fix long fixer docs (bpo-4590)
http://hg.python.org/cpython/rev/6904e229833d