Using LDFLAGS='-rpath=\$$LIB:/some/other/path' ./configure breaks the build

[flub]

BPO	5201
Nosy	@tarekziade
Files	makevars.diff: Do not consider $$ as a variable in makefile parsing makevars2.diff: Don't treat $$ as a variable but replace it by single $

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/tarekziade'
closed_at = <Date 2009-06-11.08:35:54.890>
created_at = <Date 2009-02-10.11:44:50.638>
labels = ['build', 'library']
title = "Using LDFLAGS='-rpath=\\$$LIB:/some/other/path' ./configure breaks the build"
updated_at = <Date 2009-06-11.08:35:54.888>
user = 'https://bugs.python.org/flub'

bugs.python.org fields:

activity = <Date 2009-06-11.08:35:54.888>
actor = 'tarek'
assignee = 'tarek'
closed = True
closed_date = <Date 2009-06-11.08:35:54.890>
closer = 'tarek'
components = ['Distutils']
creation = <Date 2009-02-10.11:44:50.638>
creator = 'flub'
dependencies = []
files = ['13845', '13962']
hgrepos = []
issue_num = 5201
keywords = ['patch']
message_count = 8.0
messages = ['81538', '86986', '86989', '87595', '87613', '87636', '89197', '89239']
nosy_count = 2.0
nosy_names = ['flub', 'tarek']
pr_nums = []
priority = 'normal'
resolution = None
stage = None
status = 'closed'
superseder = None
type = 'compile error'
url = 'https://bugs.python.org/issue5201'
versions = ['Python 2.6', 'Python 3.0', 'Python 3.1', 'Python 2.7']

[flub]

When specifying an RPATH with -rpath or -R you can use the special
tokens $LIB' and $ORIGIN' which the runtime linker interprets as
"normal search path" and "relative to current sofile" respectively. To
get these correctly to the gcc command line you need to specify this in
LDFLAGS as `$$LIB' to work around escapes of both the makefile and
shell, so in the Python Makefile this will appear somewhere as (this is
on one line):

CONFIG_ARGS= '--prefix=/opt/example.com/python25'
'LDFLAGS=-Wl,-rpath=\$$LIB:/opt/example.com/lib,--enable-new-dtags'

This works for compiling the main python binary. But when the extension
modules get compiled distutils chokes on this.
distutils.sysconfig.parse_makefile() does think that any value of a
variable that contains `$' in it refers to an other variable in the
makefile. It will fail to find the value and CONFIG_ARGS will not be
defined. This then fails in setup.py for the _ctypes extension:

if not '--with-system-ffi' in sysconfig.get_config_var("CONFIG_ARGS"):
            return

Where `None' is returned instead of a list by .get_config_var().

It seems that distutils.sysconfig.parse_makefile() needs to understand
more of the makefile synatax to deal with this.

[flub]

The attached patch does fix this issue.

Concerning the specific example of LDFLAGS used here there is still and
issue with LDFLAGS being ignored by the buid for the shared modules, but
that is an other issue.

[flub]

Hmm, the patch isn't quite right yet. When a $$ is present in the
makefile .parse_makefile() needs to return a single $. I'm not sure yet
what needs to happen with the \ for the shell escape.

[flub]

The updated patch inserts the single $ when needed. I've checked this
on compiling python, stdlib extension modules and custom extension
modules and this gives the correct results in all cases.

[tarekziade]

The patch looks good, beside the fact that you didn't call super() in
setUp/tearDown.

I'll commit it asap and fix that small issue

[flub]

Oh, sorry about the super() that is why the ar test failed then. Sorry,
I got a little confused by the conflicting update on that file while
working on this patch and must have merged it badly.

[flub]

Hi

What's the status of this? I haven't seen a commit message regarding this.

Cheers

[tarekziade]

done in r73341 in trunk. I've backported it as well in 2.6/3.0/3.1
branches. (r73342, r73343, r73344)

Thanks !