Distutils inappropriately reuses .o files between extension modules

[collinwinter]

BPO	5372
Nosy	@smontanaro, @tarekziade, @merwok
Files	ccompiler.patch: Patch against trunk r69982

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/tarekziade'
closed_at = <Date 2010-01-11.23:24:06.505>
created_at = <Date 2009-02-26.00:05:26.582>
labels = ['type-bug', 'library']
title = 'Distutils inappropriately reuses .o files between extension modules'
updated_at = <Date 2012-05-04.03:16:33.913>
user = 'https://bugs.python.org/collinwinter'

bugs.python.org fields:

activity = <Date 2012-05-04.03:16:33.913>
actor = 'eric.araujo'
assignee = 'tarek'
closed = True
closed_date = <Date 2010-01-11.23:24:06.505>
closer = 'tarek'
components = ['Distutils']
creation = <Date 2009-02-26.00:05:26.582>
creator = 'collinwinter'
dependencies = []
files = ['13180']
hgrepos = []
issue_num = 5372
keywords = ['patch', 'needs review']
message_count = 5.0
messages = ['82734', '97493', '97556', '97614', '159895']
nosy_count = 5.0
nosy_names = ['skip.montanaro', 'collinwinter', 'jyasskin', 'tarek', 'eric.araujo']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue5372'
versions = ['Python 2.6', 'Python 3.1', 'Python 2.7', 'Python 3.2']

[collinwinter]

(Tarek, I've been told you're the new distutils maintainer. Feel free to
unassign this if that isn't the case.)

The test distutils uses to decide whether it needs to recompile an
existing .o file when building extension modules is too simplistic,
merely comparing the modification time of the .o and .c files. If you
have two extension modules like so

Extension('foo', ['foo.c', 'bar.c'],
define_macros=[('NO_STATIC_MEMOTABLE', 1)])

Extension('bar', ['bar.c'])

even if defining NO_STATIC_MEMOTABLE=1 radically changes the code of
bar.c, distutils will use the same bar.o for both the foo and bar
extension modules. This was a real problem for me at work today.

The attached patch removes the modtime comparison entirely, preferring
to rebuild all .o files a given extension module needs. Note that while
_prep_compiler() isn't used anywhere in the stdlib, Google Code Search
turns up uses.

[smontanaro]

LGTM. Nothing is quite as satisfying as simply deleting a bunch of
logic/lines.

[tarekziade]

This optimization is indeed simplistic.

I'll also remove _prep_compiler() in trunk, as I don't see a problem in removing it in the 2.7.x and 3.2.x series.

I also need to fix it in 2.6.x / 3.1.x, but I'll keep the private method there.

[tarekziade]

done in r77424, r77425, r77427, r77430

Thanks Collin !

[merwok]

See also bpo-14517.