Menu deletecommand fails if command is already deleted

[gregcouch]

BPO	6270
Nosy	@asvetlov, @csabella
Files	delcmd.patch: revised deletecommand patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2018-05-04.12:30:27.967>
created_at = <Date 2009-06-11.21:09:39.115>
labels = ['type-bug', 'expert-tkinter']
title = 'Menu deletecommand fails if command is already deleted'
updated_at = <Date 2018-05-04.12:30:27.951>
user = 'https://bugs.python.org/gregcouch'

bugs.python.org fields:

activity = <Date 2018-05-04.12:30:27.951>
actor = 'cheryl.sabella'
assignee = 'gpolo'
closed = True
closed_date = <Date 2018-05-04.12:30:27.967>
closer = 'cheryl.sabella'
components = ['Tkinter']
creation = <Date 2009-06-11.21:09:39.115>
creator = 'gregcouch'
dependencies = []
files = ['14266']
hgrepos = []
issue_num = 6270
keywords = ['patch']
message_count = 3.0
messages = ['89262', '220772', '316168']
nosy_count = 5.0
nosy_names = ['gregcouch', 'gpolo', 'asvetlov', 'BreamoreBoy', 'cheryl.sabella']
pr_nums = []
priority = 'normal'
resolution = 'out of date'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue6270'
versions = ['Python 3.1', 'Python 2.7', 'Python 3.2']

[gregcouch]

Sometime around Python 2.5.4, Menu.delete was changed to delete
associated entry commands (and thus plug a memory leak). This broke
Pmw.OptionMenu because it already had similar code, so when Menu.delete
was called, the commands were already gone, and a TclError was raised
saying "can't delete Tcl command".

While Pmw could be patched to workaround this bug, it seems strange that
Tkinter.Misc.deletecommand unconditionally deletes commands it knows
nothing about. All uses of deletecommand in Tkinter refer to commands
that were Tkinter.Misc._register'ed, so they should appear in the
widget._tclCommands list. So the proper solution is to only delete
commands that are still registered with the widget.

Repeat by:

import Pmw
om = Pmw.OptionMenu()
om.pack()
om.setitems(['a', 'b'])
om.setitems(['b'])

[BreamoreBoy]

I've tried to reproduce this on Windows 7 with Python 3.4.1 and failed. Would somebody else please give it a go.

[csabella]

I installed the latest version of pmw on Ubuntu 14.04 and did not receive any errors using the supplied test snippet. It appears that pmw added a patch to the code to only delete the commands when used with Python versions before 2.5.4 so that this bug would not be triggered.

This could be revisited if someone else runs into an issue with deletecommand, but closing for now as out of date.