test_telnetlib doesn't test Telnet.write

[jackdied]

BPO	6582
Nosy	@jackdied
Files	telnetlib_writetest.diff

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/jackdied'
closed_at = <Date 2009-09-03.20:38:47.462>
created_at = <Date 2009-07-26.22:30:31.829>
labels = ['easy', 'tests']
title = "test_telnetlib doesn't test Telnet.write"
updated_at = <Date 2009-09-03.21:04:46.622>
user = 'https://github.com/jackdied'

bugs.python.org fields:

activity = <Date 2009-09-03.21:04:46.622>
actor = 'rwanderley'
assignee = 'jackdied'
closed = True
closed_date = <Date 2009-09-03.20:38:47.462>
closer = 'jackdied'
components = ['Tests']
creation = <Date 2009-07-26.22:30:31.829>
creator = 'jackdied'
dependencies = []
files = ['14686']
hgrepos = []
issue_num = 6582
keywords = ['patch', 'easy']
message_count = 6.0
messages = ['90963', '90967', '91361', '91498', '92218', '92220']
nosy_count = 2.0
nosy_names = ['jackdied', 'rwanderley']
pr_nums = []
priority = 'normal'
resolution = 'accepted'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue6582'
versions = ['Python 2.7', 'Python 3.2']

[jackdied]

test/test_telnetlib.py has zero tests for the telnetlib.Telnet.write method.

[jackdied]

Marking as easy. What needs to be done is to add a small fake socket
class that redefines socket.sendall(self, bytes) to capture the args to
sock.sendall so it can be assertEqual'd to the expected bytes.

class SocketSendall(socket.socket):
  _raw_sent = b''
  def sendall(self, data):
    self._raw_sent += data

class TelnetSockSendall(telnetlib.Telnet):
  def open(self, *args, **opts):
    ''' a near-exact copy of Telnet.open '''
    # copy 5 lines from Telnet.open here
    self.sock = SocketSendall(*args, **opts)

then add a unit test that checks the ONLY thing Telnet.write() does,
which is change IAC to IAC+IAC.

[rwanderley]

Did only minor modifications to TelnetSocketSendall class.

Please review the following patch.

[jackdied]

Thanks Rodrigo, I'll integrate this and check it in.

[jackdied]

applied in r74638
and I've added you to Misc/ACKS
Thanks again for the patch!

[rwanderley]

On Thu, 03 Sep 2009 20:38:49 +0000
Jack Diederich <report@bugs.python.org> wrote:

Jack Diederich <jackdied@gmail.com> added the comment:

applied in r74638
and I've added you to Misc/ACKS
Thanks again for the patch!

No problem,

Anything I can do to improve telnetlib further?

I'm currently with plenty of time available and would appreciate the
opportunity to learn more Python.

Rodrigo

----------
resolution: -> accepted
status: open -> closed

---

Python tracker <report@bugs.python.org>
<http://bugs.python.org/issue6582\>

---