suspicious comment in msilib.py/__init__.py

[janssen]

BPO	8554
Nosy	@loewis

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2011-03-30.05:34:01.931>
created_at = <Date 2010-04-28.01:31:30.563>
labels = ['library', 'OS-windows']
title = 'suspicious comment in msilib.py/__init__.py'
updated_at = <Date 2011-03-30.05:34:01.930>
user = 'https://bugs.python.org/janssen'

bugs.python.org fields:

activity = <Date 2011-03-30.05:34:01.930>
actor = 'loewis'
assignee = 'none'
closed = True
closed_date = <Date 2011-03-30.05:34:01.931>
closer = 'loewis'
components = ['Library (Lib)', 'Windows']
creation = <Date 2010-04-28.01:31:30.563>
creator = 'janssen'
dependencies = []
files = []
hgrepos = []
issue_num = 8554
keywords = []
message_count = 4.0
messages = ['104393', '116575', '132226', '132547']
nosy_count = 4.0
nosy_names = ['loewis', 'janssen', 'BreamoreBoy', 'markm']
pr_nums = []
priority = 'low'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue8554'
versions = ['Python 2.6']

[janssen]

Take a look at the first line of make_id(). What does that comment mean? Is the wrong line commented out?

def make_id(str, add_num=True):
    #str = str.replace(".", "_") # colons are allowed

[BreamoreBoy]

The line in question has been like that since r42847 i.e. when the file came into existence.

[markm]

Per: http://msdn.microsoft.com/en-us/library/aa369212(v=vs.85).aspx
"""The Identifier data type is a text string. Identifiers may contain the
ASCII characters A-Z (a-z), digits, underscores (_), or periods (.). However, every identifier must begin with either a letter or an underscore."""

So the spec would say that colons are NOT allowed. Editing some entries in the File table of an MSI (using Orca from the MSI SDK) and running the validation confirms that.

All the following were flagged as errors during validation:
'KDiff3EXE;"ASDF@#$', 'chmFile-', 'pdfFile(', 'hgbook]', 'TortoisePlinkEXE]', 'Hg.Cämd', 'merg:epatterns.rc'

I think that this issue should be fixed when bpo-2694 is fixed. (I would like to put together some tests and patch for that :)

[markm]

This issue has been fixed when bpo-11696 was fixed.