test_urllibnet failure

[pitrou]

BPO	8963
Nosy	@loewis, @abalkin, @orsenthil, @pitrou, @davidmalcolm
Files	issue8963.diff

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2012-03-15.05:37:09.424>
created_at = <Date 2010-06-10.19:07:17.789>
labels = ['tests', 'type-bug', 'library', 'invalid']
title = 'test_urllibnet failure'
updated_at = <Date 2012-03-15.05:37:09.422>
user = 'https://github.com/pitrou'

bugs.python.org fields:

activity = <Date 2012-03-15.05:37:09.422>
actor = 'orsenthil'
assignee = 'none'
closed = True
closed_date = <Date 2012-03-15.05:37:09.424>
closer = 'orsenthil'
components = ['Library (Lib)', 'Tests']
creation = <Date 2010-06-10.19:07:17.789>
creator = 'pitrou'
dependencies = []
files = ['17608']
hgrepos = []
issue_num = 8963
keywords = ['patch']
message_count = 21.0
messages = ['107470', '107472', '107473', '107474', '107475', '107476', '107477', '107478', '107480', '107481', '107482', '107483', '107484', '107485', '107486', '107490', '107494', '107496', '107497', '155387', '155859']
nosy_count = 6.0
nosy_names = ['loewis', 'belopolsky', 'orsenthil', 'pitrou', 'dmalcolm', 'rosslagerwall']
pr_nums = []
priority = 'normal'
resolution = 'not a bug'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue8963'
versions = ['Python 2.6', 'Python 3.1', 'Python 2.7', 'Python 3.2']

[pitrou]

This test failure just happened to me on a py3k checkout:

test test_urllibnet failed -- Traceback (most recent call last):
  File "/home/antoine/py3k/debug/Lib/test/test_urllibnet.py", line 191, in test_data_header
    time.strptime(datevalue, dateformat)
  File "/home/antoine/py3k/debug/Lib/_strptime.py", line 461, in _strptime_time
    return _strptime(data_string, format)[0]
  File "/home/antoine/py3k/debug/Lib/_strptime.py", line 332, in _strptime
    (data_string, format))
ValueError: time data 'Thu, 10 Jun 2010 19:03:39 GMT' does not match format '%a, %d %b %Y %H:%M:%S GMT'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/antoine/py3k/debug/Lib/test/test_urllibnet.py", line 193, in test_data_header
    self.fail('Date value not in %r format', dateformat)
TypeError: fail() takes at most 2 arguments (3 given)

[abalkin]

How do I enable `network' resource?

I am getting

$ ./python.exe -m test.regrtest test_urllibnet
test_urllibnet
test_urllibnet skipped -- Use of the `network' resource not enabled
1 test skipped:
    test_urllibnet
Those skips are all expected on darwin.

Same on Linux ...

[pitrou]

How do I enable `network' resource?

Use the "-unetwork" flag to regrtest.

[abalkin]

$ ./python.exe -m test.regrtest -unetwork test_urllibnet
test_urllibnet
1 test OK.

Also the arguments to strptime from reported error message work fine:

>>> import time
>>> time.strptime('Thu, 10 Jun 2010 19:03:39 GMT', '%a, %d %b %Y %H:%M:%S GMT')
time.struct_time(tm_year=2010, tm_mon=6, tm_mday=10, tm_hour=19, tm_min=3, tm_sec=39, tm_wday=3, tm_yday=161, tm_isdst=-1)
>>> from datetime import *
>>> datetime.strptime('Thu, 10 Jun 2010 19:03:39 GMT', '%a, %d %b %Y %H:%M:%S GMT')
datetime.datetime(2010, 6, 10, 19, 3, 39)

[abalkin]

What is your locale?

[pitrou]

What is your locale?

$ locale
LANG=fr_FR.utf8
LC_CTYPE="fr_FR.utf8"
LC_NUMERIC="fr_FR.utf8"
LC_TIME="fr_FR.utf8"
LC_COLLATE="fr_FR.utf8"
LC_MONETARY="fr_FR.utf8"
LC_MESSAGES="fr_FR.utf8"
LC_PAPER="fr_FR.utf8"
LC_NAME="fr_FR.utf8"
LC_ADDRESS="fr_FR.utf8"
LC_TELEPHONE="fr_FR.utf8"
LC_MEASUREMENT="fr_FR.utf8"
LC_IDENTIFICATION="fr_FR.utf8"
LC_ALL=

[pitrou]

Strangely, it also works here from the prompt:

>>> import time
>>> time.strptime('Thu, 10 Jun 2010 19:03:39 GMT', '%a, %d %b %Y %H:%M:%S GMT')
time.struct_time(tm_year=2010, tm_mon=6, tm_mday=10, tm_hour=19, tm_min=3, tm_sec=39, tm_wday=3, tm_yday=161, tm_isdst=-1)
>>> import locale
>>> locale.getlocale(locale.LC_TIME)
(None, None)

Apparently, something sets the locale before running the test.

[abalkin]

I still cannot reproduce the failure, but please, try the attached patch.

[pitrou]

The culprit seems to be test_bad_address. If I disable this test, or replace the bad URL by a good one, everything works fine. It seems that failing to resolve the domain name changes the current locale...

[pitrou]

The patch is not sufficient, since other failures can then occur if test_strptime gets run after test_urllibnet:

======================================================================
ERROR: test_twelve_noon_midnight (test.test_strptime.Strptime12AMPMTests)
----------------------------------------------------------------------

Traceback (most recent call last):
  File "/home/antoine/py3k/debug/Lib/test/test_strptime.py", line 389, in test_twelve_noon_midnight
    eq(time.strptime('12 PM', '%I %p')[3], 12)
  File "/home/antoine/py3k/debug/Lib/_strptime.py", line 461, in _strptime_time
    return _strptime(data_string, format)[0]
  File "/home/antoine/py3k/debug/Lib/_strptime.py", line 335, in _strptime
    data_string[found.end():])
ValueError: unconverted data remains: PM

======================================================================
FAIL: test_pattern (test.test_strptime.TimeRETests)
----------------------------------------------------------------------

Traceback (most recent call last):
  File "/home/antoine/py3k/debug/Lib/test/test_strptime.py", line 124, in test_pattern
    pattern_string)
AssertionError: did not find abbreviated weekday in pattern string '(?P<a>lun\.|mar\.|mer\.|jeu\.|ven\.|sam\.|dim\.)\s+(?P<A>mercredi|vendredi|dimanche|samedi|lundi|mardi|jeudi)\s+(?P<d>3[0-1]|[1-2]\d|0[1-9]|[1-9]| [1-9])'

======================================================================
FAIL: test_hour (test.test_strptime.StrptimeTests)
----------------------------------------------------------------------

Traceback (most recent call last):
  File "/home/antoine/py3k/debug/Lib/test/test_strptime.py", line 266, in test_hour
    (strf_output, strp_output[3], self.time_tuple[3]))
AssertionError: testing of '%I %p' directive failed; '08 ' -> 8 != 20

---

[abalkin]

BTW, looking at test_bad_address(), I wonder why it puts extra dots in the url? The comment above it suggests that the intent is to use a name within RFC 2606 .invalid TLD. Not likely to be a problem in your case, but using made up TLD is not a good idea.