ResourceWarning: unclosed file <_io.TextIOWrapper

[cjejuni2000]

BPO	11342
Nosy	@tarekziade, @merwok, @Trundle
Files	distutils-files.diff

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/merwok'
closed_at = <Date 2011-05-26.16:53:58.778>
created_at = <Date 2011-02-26.21:38:57.771>
labels = []
title = 'ResourceWarning: unclosed file <_io.TextIOWrapper'
updated_at = <Date 2011-05-26.16:53:58.777>
user = 'https://bugs.python.org/cjejuni2000'

bugs.python.org fields:

activity = <Date 2011-05-26.16:53:58.777>
actor = 'eric.araujo'
assignee = 'eric.araujo'
closed = True
closed_date = <Date 2011-05-26.16:53:58.778>
closer = 'eric.araujo'
components = []
creation = <Date 2011-02-26.21:38:57.771>
creator = 'cjejuni2000'
dependencies = []
files = ['20934']
hgrepos = []
issue_num = 11342
keywords = ['patch']
message_count = 21.0
messages = ['129598', '129599', '129632', '129637', '129671', '129673', '129681', '129697', '129716', '129819', '129849', '129852', '129853', '129854', '129855', '130016', '131552', '131581', '131585', '131586', '136983']
nosy_count = 6.0
nosy_names = ['nadeem.vawda', 'tarek', 'eric.araujo', 'Trundle', 'alexis', 'cjejuni2000']
pr_nums = []
priority = 'normal'
resolution = 'works for me'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue11342'
versions = []

[cjejuni2000]

1 test failed:
test_urllib2_localnet
1 test altered the execution environment:
test_urllib2
21 tests skipped:
test_codecmaps_cn test_codecmaps_hk test_codecmaps_jp
test_codecmaps_kr test_codecmaps_tw test_curses test_gdb
test_kqueue test_ossaudiodev test_smtpnet test_socketserver
test_startfile test_timeout test_tk test_ttk_guionly
test_urllib2net test_urllibnet test_winreg test_winsound
test_xmlrpc_net test_zipfile64
1 skip unexpected on linux2:
test_ttk_guionly
sys:1: ResourceWarning: unclosed file <_io.TextIOWrapper name='/dev/null' mode='a' encoding='UTF-8'>
make: *** [test] Error 1

[cjejuni2000]

[ 92/349] test_distutils
/home/les/Downloads/Python-3.2/Lib/distutils/command/sdist.py:197: ResourceWarning: unclosed file <_io.TextIOWrapper name='MANIFEST.in' mode='r' encoding='UTF-8'>
self.read_template()
unknown, 0: Warning: using regular magic file /etc/magic' unknown, 0: Warning: using regular magic file /etc/magic'

[merwok]

Does the attached patch fix the issue?

[Trundle]

@Éric: You should probably strip the colour from your diff :-)

[cjejuni2000]

hi eric: thanks for the reply. here is what i'm getting from 'patch --dry-run' command:

les@Liquid:/Desktop$ patch -i ~/Desktop/distutils_files.diff -d ~/Downloads/Python-3.2/Lib/distutils --dry-run --backup
patching file bdist_wininst.py
Hunk #1 FAILED at 245.
1 out of 1 hunk FAILED -- saving rejects to file bdist_wininst.py.rej
patching file bdist_rpm.py
Hunk #1 FAILED at 511.
1 out of 1 hunk FAILED -- saving rejects to file bdist_rpm.py.rej
patching file upload.py
Hunk #1 FAILED at 124.
1 out of 1 hunk FAILED -- saving rejects to file upload.py.rej
patching file sdist.py
Hunk #1 FAILED at 294.
Hunk #2 FAILED at 359.
2 out of 2 hunks FAILED -- saving rejects to file sdist.py.rej
patching file sysconfig.py
les@Liquid:/Desktop$

[merwok]

Can you test with a checkout of the py3k branch? http://docs.python.org/devguide/setup#checking-out-the-code

[cjejuni2000]

seemed no errors. end of check attach:

U py3k
Checked out revision 88674.

[merwok]

So the patch fixes the resource warnings?

[cjejuni2000]

only the sysconfig.py was patched, the rest were "reject'ed." no compilation yet at this time.