possible typo in multiprocessing.Pool._terminate

[pitrou]

BPO	11814
Nosy	@pitrou

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2011-04-10.22:31:25.806>
created_at = <Date 2011-04-09.23:07:20.206>
labels = []
title = 'possible typo in multiprocessing.Pool._terminate'
updated_at = <Date 2011-04-10.22:31:25.805>
user = 'https://github.com/pitrou'

bugs.python.org fields:

activity = <Date 2011-04-10.22:31:25.805>
actor = 'pitrou'
assignee = 'none'
closed = True
closed_date = <Date 2011-04-10.22:31:25.806>
closer = 'pitrou'
components = []
creation = <Date 2011-04-09.23:07:20.206>
creator = 'pitrou'
dependencies = []
files = []
hgrepos = []
issue_num = 11814
keywords = []
message_count = 3.0
messages = ['133433', '133486', '133489']
nosy_count = 4.0
nosy_names = ['pitrou', 'jnoller', 'asksol', 'python-dev']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue11814'
versions = ['Python 3.1', 'Python 3.2', 'Python 3.3']

[pitrou]

There's the following code in pool.py, line 494 and following:

        debug('joining task handler')
        task_handler.join()

        debug('joining result handler')
        task_handler.join()

It seems the last line should read result_handler.join() instead.

Additionally, when _terminate() is called, it seems the worker_handler could still run while other threads shut down existing workers, meaning it could start new workers (in _repopulate_pool()) in parallel.

So perhaps the worker_handler should be joined before anything else in _terminate(). It would incur a small latency, though (because of the sleep() call there).

[python-dev]

New changeset c046b7e1087b by Antoine Pitrou in branch '3.2':
Issue bpo-11814: Fix likely typo in multiprocessing.Pool._terminate().
http://hg.python.org/cpython/rev/c046b7e1087b

New changeset 76a3fc180ce0 by Antoine Pitrou in branch 'default':
Merge from 3.2 (issue bpo-11814, issue bpo-8428)
http://hg.python.org/cpython/rev/76a3fc180ce0

[pitrou]

Fixed. The _terminate() issue has been fixed separately in bpo-8428.