What's New multiprocessing example error

[davipo]

BPO	12042
Nosy	@rhettinger, @ezio-melotti, @merwok, @bitdancer, @sandrotosi
Files	issue12042_2.7.patch: Queue is used to communicate the result only, changed doc to reflect this. issue12042_31.patch: Doc update for 3.1 -- Queue communicates result issue12042_32.patch: Doc update for 3.2 -- Queue communicates result

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2012-01-05.18:55:11.887>
created_at = <Date 2011-05-09.18:55:11.552>
labels = ['docs']
title = "What's New multiprocessing example error"
updated_at = <Date 2012-01-05.18:55:11.885>
user = 'https://bugs.python.org/davipo'

bugs.python.org fields:

activity = <Date 2012-01-05.18:55:11.885>
actor = 'sandro.tosi'
assignee = 'docs@python'
closed = True
closed_date = <Date 2012-01-05.18:55:11.887>
closer = 'sandro.tosi'
components = ['Documentation']
creation = <Date 2011-05-09.18:55:11.552>
creator = 'davipo'
dependencies = []
files = ['22002', '22127', '22128']
hgrepos = []
issue_num = 12042
keywords = ['patch']
message_count = 15.0
messages = ['135626', '135821', '135944', '135979', '136658', '136676', '136677', '136681', '136985', '137014', '137015', '137023', '137063', '150681', '150682']
nosy_count = 9.0
nosy_names = ['rhettinger', 'ezio.melotti', 'eric.araujo', 'davipo', 'r.david.murray', 'sandro.tosi', 'docs@python', 'python-dev', 'jstadler']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue12042'
versions = ['Python 2.7', 'Python 3.2', 'Python 3.3']

[davipo]

In this section:
http://docs.python.org/whatsnew/2.6.html#pep-371-the-multiprocessing-package

This sentence follows the first example:
"A Queue is used to communicate the input parameter N and the result."

In the example, the queue is used only for the result, not the input parameter N.

[P.S. I'd be happy to submit corrections, but don't want to have to install and learn Mercurial. Is there a simpler way?]

[ezio-melotti]

The workflow to prepare a patch using Mercurial is pretty much the same as SVN:

# get a clone (checkout) of the repository
hg clone http://hg.python.org/cpython
# select the branch where you want to fix the issue
hg update 2.7
# make changes on the file(s) and make a patch
hg diff > bpo-12042.diff

See also http://docs.python.org/devguide/setup.html
Also note that 2.6 only receives security fixes, so it can't be fixed there. All the "whatsnew" files are also included in the following versions though, so it might be worth preparing a patch against 2.7.

[jstadler]

I'll prepare the patch if davipo doesn't want to. I'm trying to become more comfortable with the patching process and this seems simple enough for me to handle.

[jstadler]

Patch is up for 2.7, minor change in the documentation.

[merwok]

I’m not sure historical whatsnew documents get fixes. As long as the PEPs and docs get fixes, the whatsnew can stay as they are.

[davipo]

The What's New docs are the place to find information on changes between versions. Upgrading to 2.7 from 2.5, I needed to read the 2.6 and 2.7 What's New docs to learn what changes I should be aware of. I hope errors in these docs will be fixed, at least for a few versions back. (This particular fix is not so important, but I'm trying to practice the habit of at least reporting problems I see, to make a contribution to Python.)

[jstadler]

Alright, should it be closed if we aren't going to touch it?

[merwok]

Let’s fix it in the open branches.

[jstadler]

Alright, patches are up for 3.1 and 3.2. I'm not sure if I can just make one for the 3.x's so I made both.

[davipo]

Thanks Jordan. How about 2.7? Is that not an open branch?

--Davi

On Thu, May 26, 2011 at 12:17 PM, Jordan Stadler <report@bugs.python.org>wrote:

Jordan Stadler <jordan.stadler@gmail.com> added the comment:

Alright, patches are up for 3.1 and 3.2. I'm not sure if I can just make
one for the 3.x's so I made both.

----------

---

Python tracker <report@bugs.python.org>
<http://bugs.python.org/issue12042\>

---

[jstadler]

To be honest, I'm getting a bit confused as to what is required. I thought the two most important patches would be 2.7 and 3.2, but we have 2.7, 3.1, 3.2, and 3.3 listed as versions affected.

I posted the patch for 2.7 originally on May 14th. I'm not sure if there is a problem with that patch I posted, but Eric didn't seem content with the versions. At this time versions 3.1, 3.2, and 3.3 were added to the affected versions list.

Today I did the patches for 3.1 and 3.2, but I am unsure of how to provide one for 3.3 as is is not listed in mercurial for me (I'm probably doing something wrong, but I couldn't see it).

The change in the patch is so minor and I don't mind doing 3.3 if I can get my mercurial to update to 3.3. If the change I made in the patches is insufficient please let me know, I have no problem making adjustments. I'm still getting used to the patching process and how to properly contribute to the community.

TLDR: Basically, I'm a little confused as to whether or not the patches I provided are sufficient.

[bitdancer]

Sometimes only one patch is needed, if it applies cleanly to both python2 and python3. If it doesn't, then two patches are useful, one for python2.7 and one for python3.2. (The last version of 3.1 is about to be released, so I don't think it likely that the fix will get in to that version.) We will use hg merge to merge it into 3.3, which is simply the 'default' head in the repository.

[jstadler]

Alright, thanks for the clarification, that's pretty much how I thought it worked. Patches supplied should be good then.