Improve code and tests for Mixin2to3

[merwok]

BPO	13462
Nosy	@benjaminp, @merwok

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/merwok'
closed_at = <Date 2014-03-13.00:59:20.996>
created_at = <Date 2011-11-23.16:39:00.771>
labels = ['type-bug']
title = 'Improve code and tests for Mixin2to3'
updated_at = <Date 2014-03-13.00:59:20.995>
user = 'https://github.com/merwok'

bugs.python.org fields:

activity = <Date 2014-03-13.00:59:20.995>
actor = 'eric.araujo'
assignee = 'eric.araujo'
closed = True
closed_date = <Date 2014-03-13.00:59:20.996>
closer = 'eric.araujo'
components = ['Distutils2']
creation = <Date 2011-11-23.16:39:00.771>
creator = 'eric.araujo'
dependencies = []
files = []
hgrepos = []
issue_num = 13462
keywords = []
message_count = 5.0
messages = ['148188', '148191', '148557', '153016', '153018']
nosy_count = 4.0
nosy_names = ['benjamin.peterson', 'eric.araujo', 'alexis', 'python-dev']
pr_nums = []
priority = 'normal'
resolution = 'out of date'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue13462'
versions = ['3rd party', 'Python 3.3']

[merwok]

Currently distutils2 has two classes and one function to perform 2to3 conversion in the build_py and build_scripts commands. The code is a bit messy and also lack tests, for example for the conversion of doctests in text files. I’ve started revamping it so that it’s only one class that does the work, and I will also add many tests.

Benjamin: For Python 2.4 and 2.5, should the functionality just be unavailable or is there an official release of lib2to3 on PyPI? I only found two2three, an old copy from the Subversion sandbox done by 3to2’s Joe Amenta, so I’m not sure I can be compatible with that (or if it’s even useful to try to convert 2.4 code to 3.x).

[benjaminp]

Yes, last time I checked 2to3 doesn't work on 2.5 or 2.4. People will just have to run build_py2to3 on 2.6+.

[merwok]

Thanks, I’ll adapt the code for older Pythons.

Bumped down, I won’t do this for d2 1.0a3.

[python-dev]

New changeset b024621a1be6 by Éric Araujo in branch 'default':
Start improving 2to3 code (bpo-13462).
http://hg.python.org/distutils2/rev/b024621a1be6

New changeset cc0f4d208193 by Éric Araujo in branch 'python3':
Merge fixes for bpo-13462 and others from default
http://hg.python.org/distutils2/rev/cc0f4d208193

[python-dev]

New changeset 7243c3f18769 by Éric Araujo in branch 'default':
Start improving 2to3 code in packaging (bpo-13462).
http://hg.python.org/cpython/rev/7243c3f18769