add test for defaultdict with non-callable first argument

[mikec]

BPO	13531
Nosy	@ezio-melotti
Files	defaultdict_callable_test.patch defaultdict_callable_test_v2.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/ezio-melotti'
closed_at = <Date 2011-12-07.22:08:20.155>
created_at = <Date 2011-12-05.11:55:22.663>
labels = ['easy', 'tests']
title = 'add test for defaultdict with non-callable first argument'
updated_at = <Date 2011-12-07.22:08:20.154>
user = 'https://bugs.python.org/mikec'

bugs.python.org fields:

activity = <Date 2011-12-07.22:08:20.154>
actor = 'ezio.melotti'
assignee = 'ezio.melotti'
closed = True
closed_date = <Date 2011-12-07.22:08:20.155>
closer = 'ezio.melotti'
components = ['Tests']
creation = <Date 2011-12-05.11:55:22.663>
creator = 'mike.c'
dependencies = []
files = ['23855', '23856']
hgrepos = []
issue_num = 13531
keywords = ['patch', 'easy']
message_count = 7.0
messages = ['148868', '148869', '148870', '148871', '148872', '148995', '148997']
nosy_count = 3.0
nosy_names = ['ezio.melotti', 'python-dev', 'mike.c']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue13531'
versions = ['Python 2.7', 'Python 3.2', 'Python 3.3']

[mikec]

Could a test be added to ./Lib/test/test_defaultdict.py to test for TypeError being thrown when the the first argument to collections.defaultdict is not callable?

pypy does not behave the same way as CPython 2.7.2 as the problem is not covered in the testcases.

e.g.
def test_callable_arg:
d1 = defaultdict({})
self.assertRaises(TypeError) # TypeError: first argument must be callable

[ezio-melotti]

Sure, do you want to propose a patch? (You can see the devguide for more information.)

[mikec]

Cloning repo. Reading the devguide. Patch forthcoming.

[mikec]

Patch to add a defaultdict test which checks that if the first argument is not callable, then a TypeError is thrown.

[mikec]

patch v2. Now with assertRaises()!

[python-dev]

New changeset a8deeb549e1a by Ezio Melotti in branch '2.7':
bpo-13531: add a test for defaultdict with a non-callable arg. Patch by Mike Cheng.
http://hg.python.org/cpython/rev/a8deeb549e1a

New changeset 17ceebc61b65 by Ezio Melotti in branch '3.2':
bpo-13531: add a test for defaultdict with a non-callable arg. Patch by Mike Cheng.
http://hg.python.org/cpython/rev/17ceebc61b65

New changeset 4180308547d9 by Ezio Melotti in branch 'default':
bpo-13531: merge with 3.2.
http://hg.python.org/cpython/rev/4180308547d9

[ezio-melotti]

Committed, thanks for the report and the patch!
For the record, this is related to https://bugs.pypy.org/issue953