Make use of with statement in ftplib

[giampaolo]

BPO	13563
Nosy	@pitrou, @giampaolo
Files	ftplib.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/giampaolo'
closed_at = <Date 2011-12-10.20:26:13.209>
created_at = <Date 2011-12-09.05:21:50.647>
labels = ['easy', 'library']
title = 'Make use of with statement in ftplib'
updated_at = <Date 2011-12-10.20:26:13.206>
user = 'https://github.com/giampaolo'

bugs.python.org fields:

activity = <Date 2011-12-10.20:26:13.206>
actor = 'giampaolo.rodola'
assignee = 'giampaolo.rodola'
closed = True
closed_date = <Date 2011-12-10.20:26:13.209>
closer = 'giampaolo.rodola'
components = ['Library (Lib)']
creation = <Date 2011-12-09.05:21:50.647>
creator = 'giampaolo.rodola'
dependencies = []
files = ['23889']
hgrepos = []
issue_num = 13563
keywords = ['easy']
message_count = 4.0
messages = ['149074', '149083', '149185', '149186']
nosy_count = 3.0
nosy_names = ['pitrou', 'giampaolo.rodola', 'python-dev']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue13563'
versions = ['Python 3.3']

[giampaolo]

Patch in attachment.

[pitrou]

The first hunk of the patch doesn't look right: ntransfercmd() is supposed to return the connection but the "with" statement closes it.

[python-dev]

New changeset 6cd736239b8a by Giampaolo Rodola' in branch 'default':
fix bpo-13563: make use of with statement in ftplib.py where needed
http://hg.python.org/cpython/rev/6cd736239b8a

[giampaolo]

That's why I nosyed you. Thanks. ;)