Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make use of with statement in ftplib #57772

Closed
giampaolo opened this issue Dec 9, 2011 · 4 comments
Closed

Make use of with statement in ftplib #57772

giampaolo opened this issue Dec 9, 2011 · 4 comments
Assignees
Labels
easy stdlib Python modules in the Lib dir

Comments

@giampaolo
Copy link
Contributor

giampaolo commented Dec 9, 2011

BPO 13563
Nosy @pitrou, @giampaolo
Files
  • ftplib.patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/giampaolo'
    closed_at = <Date 2011-12-10.20:26:13.209>
    created_at = <Date 2011-12-09.05:21:50.647>
    labels = ['easy', 'library']
    title = 'Make use of with statement in ftplib'
    updated_at = <Date 2011-12-10.20:26:13.206>
    user = 'https://github.com/giampaolo'

    bugs.python.org fields:

    activity = <Date 2011-12-10.20:26:13.206>
    actor = 'giampaolo.rodola'
    assignee = 'giampaolo.rodola'
    closed = True
    closed_date = <Date 2011-12-10.20:26:13.209>
    closer = 'giampaolo.rodola'
    components = ['Library (Lib)']
    creation = <Date 2011-12-09.05:21:50.647>
    creator = 'giampaolo.rodola'
    dependencies = []
    files = ['23889']
    hgrepos = []
    issue_num = 13563
    keywords = ['easy']
    message_count = 4.0
    messages = ['149074', '149083', '149185', '149186']
    nosy_count = 3.0
    nosy_names = ['pitrou', 'giampaolo.rodola', 'python-dev']
    pr_nums = []
    priority = 'normal'
    resolution = 'fixed'
    stage = None
    status = 'closed'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue13563'
    versions = ['Python 3.3']

    @giampaolo
    Copy link
    Contributor Author

    giampaolo commented Dec 9, 2011

    Patch in attachment.

    @pitrou
    Copy link
    Member

    pitrou commented Dec 9, 2011

    The first hunk of the patch doesn't look right: ntransfercmd() is supposed to return the connection but the "with" statement closes it.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Dec 10, 2011

    New changeset 6cd736239b8a by Giampaolo Rodola' in branch 'default':
    fix bpo-13563: make use of with statement in ftplib.py where needed
    http://hg.python.org/cpython/rev/6cd736239b8a

    @giampaolo
    Copy link
    Contributor Author

    giampaolo commented Dec 10, 2011

    That's why I nosyed you. Thanks. ;)

    @giampaolo giampaolo added easy stdlib Python modules in the Lib dir labels Dec 10, 2011
    @giampaolo giampaolo self-assigned this Dec 10, 2011
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    easy stdlib Python modules in the Lib dir
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants