Accessor macros for PyDateTime_Delta members

[amauryfa]

BPO	13727
Nosy	@amauryfa, @pitrou
Files	timedelta_macros.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2012-01-17.20:40:18.616>
created_at = <Date 2012-01-07.13:50:35.977>
labels = []
title = 'Accessor macros for PyDateTime_Delta members'
updated_at = <Date 2012-01-17.20:40:18.615>
user = 'https://github.com/amauryfa'

bugs.python.org fields:

activity = <Date 2012-01-17.20:40:18.615>
actor = 'amaury.forgeotdarc'
assignee = 'none'
closed = True
closed_date = <Date 2012-01-17.20:40:18.616>
closer = 'amaury.forgeotdarc'
components = []
creation = <Date 2012-01-07.13:50:35.977>
creator = 'amaury.forgeotdarc'
dependencies = []
files = ['24160']
hgrepos = []
issue_num = 13727
keywords = ['patch']
message_count = 5.0
messages = ['150796', '151410', '151411', '151412', '151486']
nosy_count = 3.0
nosy_names = ['amaury.forgeotdarc', 'pitrou', 'python-dev']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'patch review'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue13727'
versions = ['Python 3.3']

[amauryfa]

All objects of the datetime module have macros to access their properties, except timedelta.
This simple patch adds the macros PyDateTime_DELTA_GET_DAYS, PyDateTime_DELTA_GET_SECONDS, PyDateTime_DELTA_GET_MICROSECONDS; module developers are encouraged to use these instead of obj->seconds for example.

Motivation:
PyPy cannot easily expose PyDateTime_Delta fields because datetime is implemented as a pure Python module and it's difficult to rebuild a C structure from a heap type.
In PyPy these macros are actually functions, which do something similar to PyLong_AsLong(PyObject_GetAttrString(obj, "seconds")):
https://bitbucket.org/pypy/pypy/src/b67e65d709e1/pypy/module/cpyext/cdatetime.py#cl-235

[pitrou]

The macros should be named PyDelta_XXX, as PyDelta_Check and friend.
Otherwise, makes sense.

[amauryfa]

I named them following the other accessor macros: PyDateTime_TIME_GET_HOUR(), even though the check function is named PyTime_Check().
Which inconsistency do you prefer? :)

[pitrou]

Ow. Then I don't mind :)

[python-dev]

New changeset 463acb73fd79 by Amaury Forgeot d'Arc in branch 'default':
Issue bpo-13727: Add 3 macros to access PyDateTime_Delta members:
http://hg.python.org/cpython/rev/463acb73fd79