_tkinter does not build on Windows 7

[terryjreedy]

BPO	13789
Nosy	@loewis, @terryjreedy, @tjguk, @briancurtin, @stevenwinfield
Superseder	bpo-19273: Update PCbuild/readme.txt

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2013-10-25.18:31:01.324>
created_at = <Date 2012-01-15.04:59:15.780>
labels = ['type-bug', 'OS-windows', 'build']
title = '_tkinter does not build on Windows 7'
updated_at = <Date 2013-10-25.18:31:01.323>
user = 'https://github.com/terryjreedy'

bugs.python.org fields:

activity = <Date 2013-10-25.18:31:01.323>
actor = 'terry.reedy'
assignee = 'none'
closed = True
closed_date = <Date 2013-10-25.18:31:01.324>
closer = 'terry.reedy'
components = ['Build', 'Windows']
creation = <Date 2012-01-15.04:59:15.780>
creator = 'terry.reedy'
dependencies = []
files = []
hgrepos = []
issue_num = 13789
keywords = []
message_count = 5.0
messages = ['151276', '151297', '151328', '159324', '201275']
nosy_count = 6.0
nosy_names = ['loewis', 'terry.reedy', 'tim.golden', 'brian.curtin', 'steven.winfield', 'prlw1']
pr_nums = []
priority = 'normal'
resolution = 'out of date'
stage = 'resolved'
status = 'closed'
superseder = '19273'
type = 'behavior'
url = 'https://bugs.python.org/issue13789'
versions = ['Python 2.7', 'Python 3.2', 'Python 3.3']

[terryjreedy]

Modules/_tkinter.py #includes Modules/tkinter.h, tcl.h, and tk.h. The latter two #include tclDecls.h, tclPlatDecls.h, and tkDecls.h. I obtained 8.5.9 versions of all 5 and added them to Include/. Although they came from Ubuntu, they appear to be cross-platform in that they look for Mac and Win defines. They make the corresponding build errors go away. However, one remains: a failure to open X11/Xlib.h.

This must come from the following in tk.h:
#ifndef RC_INVOKED
#ifndef _XLIB_H
#   if defined(MAC_OSX_TK)
#    include <X11/Xlib.h>
#    include <X11/X.h>
#   else
#    include <X11/Xlib.h>
#   endif
#endif
#ifdef __STDC__
#   include <stddef.h>
#endif

It seems this tk.h header, at least, expects RC_INVOKED to be defined on non-X11 platforms. Something here is crucially different than on the machine that builds Python for windows. The version of tk.h? the absence of X11/xlib.h? the pcbuild stuff? or the Visual Studio version?

I tried to compile PCbuild/pcbuild.sln with VC2008 Express in the 3.3, 3.2, and 2.7 repositories. For 3.3, I tried both debug and release builds.

[loewis]

See PCbuild/readme.txt, and follow its instructions scrupulously. If you use a different build procedure, or different Tcl sources, you are on your own.

[terryjreedy]

I have read readme.txt, more than once. It seems a bit out-of-date. Parts of it I have trouble understanding, or at least, being sure I have understood. It seems to disagree with the devguide about whether to build debug or release builds. I though of opening an issue for possible readme.txt revisions.

However, my goal at the moment is to be able to test patches to IDLE .py files in repository builds on Win7, with the least fuss necessary. I have several questions:

About _tkinter, readme.txt says:
"Wraps the Tk windowing system. Unlike _sqlite3, there's no corresponding tcltk.vcproj-type project that builds Tcl/Tk from vcproj's within our pcbuild.sln, which means this module expects to find a pre-built Tcl/Tk in either ..\..\tcltk for 32-bit or ..\..\tcltk64 for 64-bit (relative to this directory). See below for instructions to build Tcl/Tk."

I interpret 'this module expects to find' to mean 'after _tkinter is
built'. If building _tkinter requires tcltk first, it should says so. (And I did try to build it, see below.)

I interpret 'this directory' to mean, on my system, '.../dev/cpython/pcbuild'. I therefore interpret '../../tcltk' to mean '.../dev/tcltk'. Experiments in Command Prompt support this.

I interpret 'pre-built Tcl/Tk' to include the pre-built Tcl/Tk already installed on my system, just as it does on *nix. I tried copying the contents of /tcl and dlls/t*.pyd from installed 3.2.2 into dev/tcltk, but that does not work. Is there any way to use the existing tcl/tk build?

As for rebuilding, the readme says "run either external.bat or
external-amd64.bat in the ..\Tools\buildbot directory from ..\, i.e.:

C:\..\svn.python.org\projects\python\trunk\PCbuild>cd ..
C:\..\svn.python.org\projects\python\trunk>Tools\buildbot\external.bat"

That exact file builds 8.5.2 instead of 8.5.9, so the above could be updated to refer to the current hg version: 'whatever/cpython> Tools...'.

external.bat runs external-common.bat. That brings all the external dependencies, which is more than I need or really want. Can I comment out the other dependencies if I want?

In any case, the file has near the top '''
@Rem XXX: If you need to force the buildbots to start from a fresh environment, uncomment
@Rem the following, check it in, then check it out, comment it out, then check it back in.
@Rem if exist tcltk rd /s/q tcltk
@Rem if exist tcltk64 rd /s/q tcltk64
'''
I do not really understand this. Does 'rd' mean 'remove directory? Can I just remove the tcltk directory I made and ignore this?

Each dependency has a line like
" svn export http://svn.python.org/projects/external/tcl-8.5.9.0"
Can I use hg export or do I need to find and install (tortoise)svn?
Are the svn urls still correct or is there an hg equivalent?

[stevenwinfield]

The tk sources (at least the 8.5.11 version I'm looking at now) have some X11 headers that can be used by the windows build in the "xlib" directory.

[terryjreedy]

I got sufficient answers on core-mentorship list to build and run.
bpo-19273 revised and updated readme.txt.