check for locale changes in test.regrtest

[brettcannon]

BPO	14135
Nosy	@brettcannon, @atsuoishimoto, @pitrou, @ezio-melotti
Files	test_14135.py: Test for checking locale changes issue14135.patch check_locale.diff

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/brettcannon'
closed_at = <Date 2013-04-01.18:12:10.862>
created_at = <Date 2012-02-26.22:47:47.849>
labels = ['easy', 'type-feature', 'tests']
title = 'check for locale changes in test.regrtest'
updated_at = <Date 2013-04-01.18:12:10.861>
user = 'https://github.com/brettcannon'

bugs.python.org fields:

activity = <Date 2013-04-01.18:12:10.861>
actor = 'brett.cannon'
assignee = 'brett.cannon'
closed = True
closed_date = <Date 2013-04-01.18:12:10.862>
closer = 'brett.cannon'
components = ['Tests']
creation = <Date 2012-02-26.22:47:47.849>
creator = 'brett.cannon'
dependencies = []
files = ['24724', '26540', '29647']
hgrepos = []
issue_num = 14135
keywords = ['patch', 'easy']
message_count = 10.0
messages = ['154414', '154856', '154857', '166573', '185742', '185743', '185745', '185750', '185752', '185754']
nosy_count = 7.0
nosy_names = ['brett.cannon', 'ishimoto', 'pitrou', 'nadeem.vawda', 'ezio.melotti', 'westley.martinez', 'python-dev']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'needs patch'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue14135'
versions = ['Python 3.4']

[brettcannon]

Issue bpo-14113 pointed out that test.support doesn't check if tests mucked with the locale after running.

[westleymartinez]

Here's a test that checks for changes to the locale.

[ezio-melotti]

Thanks for the patch, but I think Brett meant to say that this should be added to Lib/test/regrtest.py:750, among the other resources.

[atsuoishimoto]

Patch to check if locale was changed.

Since I'm not sure where to put tests for test.regrtest, I created
new file, test.test_regrtest.

[python-dev]

New changeset 4fcd50a6dca7 by Brett Cannon in branch 'default':
Issue bpo-14135: Make sure tests don't leave the locale changed for any
http://hg.python.org/cpython/rev/4fcd50a6dca7

[brettcannon]

Sorry it took so wrong to get to this. It simply fell out of my purview.

[pitrou]

I had to back out this changeset as it totally broke the test suite here:

[ 91/372/90] test_defaultdict
test test_defaultdict crashed -- Traceback (most recent call last):
  File "/home/antoine/cpython/default/Lib/test/regrtest.py", line 1287, in runtest_inner
    with saved_test_environment(test, verbose, quiet) as environment:
  File "/home/antoine/cpython/default/Lib/test/regrtest.py", line 1251, in __enter__
    in self.resource_info())
  File "/home/antoine/cpython/default/Lib/test/regrtest.py", line 1250, in <genexpr>
    self.saved_values = dict((name, get()) for name, get, restore
  File "/home/antoine/cpython/default/Lib/test/regrtest.py", line 1237, in get_locale
    return tuple(map(locale.getlocale, self._locale_categories))
  File "/home/antoine/cpython/default/Lib/locale.py", line 523, in getlocale
    raise TypeError('category LC_ALL is not supported')
TypeError: category LC_ALL is not supported

(etc.)

[brettcannon]

Can you check the attached patch works for you, Antoine?