ref-counting leak in buffer usage in Python/marshal.c

[scoder]

BPO	14172
Nosy	@pitrou, @scoder, @skrah
Files	marshalbufs.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2012-03-02.17:23:45.461>
created_at = <Date 2012-03-02.09:42:58.507>
labels = ['interpreter-core', 'type-bug']
title = 'ref-counting leak in buffer usage in Python/marshal.c'
updated_at = <Date 2012-03-02.17:23:45.460>
user = 'https://github.com/scoder'

bugs.python.org fields:

activity = <Date 2012-03-02.17:23:45.460>
actor = 'pitrou'
assignee = 'none'
closed = True
closed_date = <Date 2012-03-02.17:23:45.461>
closer = 'pitrou'
components = ['Interpreter Core']
creation = <Date 2012-03-02.09:42:58.507>
creator = 'scoder'
dependencies = []
files = ['24708']
hgrepos = []
issue_num = 14172
keywords = ['patch']
message_count = 4.0
messages = ['154755', '154775', '154783', '154784']
nosy_count = 4.0
nosy_names = ['pitrou', 'scoder', 'skrah', 'python-dev']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue14172'
versions = ['Python 3.2', 'Python 3.3']

[scoder]

Line 428 in Python/marshal.c calls pb->bf_releasebuffer() without dec-refing the view.obj field afterwards. I don't think this is really so truly performance critical that it can't accept the couple of nanoseconds that it takes to go through PyBuffer_Release() instead.

[pitrou]

Here is a patch.

[python-dev]

New changeset 185a6ae76479 by Antoine Pitrou in branch '3.2':
Issue bpo-14172: Fix reference leak when marshalling a buffer-like object (other than a bytes object).
http://hg.python.org/cpython/rev/185a6ae76479

New changeset b1303cf15e01 by Antoine Pitrou in branch 'default':
Issue bpo-14172: Fix reference leak when marshalling a buffer-like object (other than a bytes object).
http://hg.python.org/cpython/rev/b1303cf15e01

[pitrou]

Fixed. Apparently 2.7 isn't affected.