sftp: downloading files with % in name fails due to logging

[darugar]

BPO	14395
Nosy	@bitdancer

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2012-03-26.00:54:59.661>
created_at = <Date 2012-03-23.21:51:39.416>
labels = ['type-bug', 'invalid']
title = 'sftp: downloading files with % in name fails due to logging'
updated_at = <Date 2012-03-26.06:57:18.051>
user = 'https://bugs.python.org/darugar'

bugs.python.org fields:

activity = <Date 2012-03-26.06:57:18.051>
actor = 'darugar'
assignee = 'none'
closed = True
closed_date = <Date 2012-03-26.00:54:59.661>
closer = 'r.david.murray'
components = []
creation = <Date 2012-03-23.21:51:39.416>
creator = 'darugar'
dependencies = []
files = []
hgrepos = []
issue_num = 14395
keywords = []
message_count = 3.0
messages = ['156678', '156794', '156799']
nosy_count = 2.0
nosy_names = ['r.david.murray', 'darugar']
pr_nums = []
priority = 'normal'
resolution = 'not a bug'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue14395'
versions = ['3rd party']

[darugar]

Attempting to download a file with a "%" as part of the name (eg. "test%sfile") , sftp.get fails with:

File "/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/logging/init.py", line 328, in getMessage
msg = msg % self.args
TypeError: not enough arguments for format string

This appears to be because of the logging in sftp.py:

    def _log(self, level, msg, *args):
        self.logger.log(level, msg, *args)

I'm able to work around it by escaping the "%" to "%%" before calling sftp.get .

[bitdancer]

There is no sftp module in the standard library. Presumably you are talking about a 3rd party product and should report the bug to its developers.

If you are trying instead to report a bug in the logging module, please reopen the issue if you can provide a simple example of triggering the bug you believe exists. (It is much more likely to be a bug in sftp.py).

[darugar]

You're absolutely right, it's from paramiko. Apologies.