(2.7.3 Regression) PC\8.0 directory can no longer be used to build on windows

[mitchblank]

BPO	14559
Nosy	@tjguk, @zware, @zooba

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2015-02-19.16:21:44.566>
created_at = <Date 2012-04-12.07:24:22.803>
labels = ['build', 'OS-windows']
title = '(2.7.3 Regression)  PC\\8.0 directory can no longer be used to build on windows'
updated_at = <Date 2015-02-19.16:21:44.565>
user = 'https://bugs.python.org/mitchblank'

bugs.python.org fields:

activity = <Date 2015-02-19.16:21:44.565>
actor = 'steve.dower'
assignee = 'none'
closed = True
closed_date = <Date 2015-02-19.16:21:44.566>
closer = 'steve.dower'
components = ['Windows']
creation = <Date 2012-04-12.07:24:22.803>
creator = 'mitchblank'
dependencies = []
files = []
hgrepos = []
issue_num = 14559
keywords = []
message_count = 3.0
messages = ['158110', '158190', '236218']
nosy_count = 6.0
nosy_names = ['tim.golden', 'BreamoreBoy', 'python-dev', 'zach.ware', 'mitchblank', 'steve.dower']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = 'compile error'
url = 'https://bugs.python.org/issue14559'
versions = ['Python 2.7']

[mitchblank]

In the diff between 2.7.2 and 2.7.3, we see:

--- Python-2.7.2/PCbuild/pythoncore.vcproj      2011-06-11 08:46:27.000000000 -0700
+++ Python-2.7.3/PCbuild/pythoncore.vcproj      2012-04-09 16:07:35.000000000 -0700
@@ -1835,6 +1835,10 @@
                                >
                        </File>
                        <File
+                               RelativePath="..\Python\random.c"
+                               >
+                       </File>
+                       <File
                                RelativePath="..\Python\structmember.c"
                                >
                        </File>

...however there isn't any similar change to PC\VS8.0\pythoncore.vcproj , PC\VS7.1\pythoncore.vcproj, nor PC\VC6\pythoncore.dsp

I don't know if any of those are deprecated, but the VS8.0 .vcproj's definitely worked in 2.7.2. In 2.7.3 the missing random.obj file causes python27.dll to fail to link and everything goes downhill from there.

Hand-applying the same change to the PC\VS8.0 directory fixed the problem for me.

[python-dev]

New changeset 9a6dc460ecb2 by Amaury Forgeot d'Arc in branch '2.7':
bpo-14559: Attempt to fix compilation with previous versions of the Microsoft Compiler.
http://hg.python.org/cpython/rev/9a6dc460ecb2

New changeset 178acd78144b by Amaury Forgeot d'Arc in branch '3.2':
bpo-14559: Fix build files old Microft compilers.
http://hg.python.org/cpython/rev/178acd78144b

[BreamoreBoy]

Presumably this can be closed as fixed?