PyErr_SetFromImportErrorWithNameAndPath lacks error checking

[pitrou]

BPO	14593
Nosy	@brettcannon, @pitrou, @briancurtin, @ericsnowcurrently
Superseder	bpo-14600: Change ImportError reference handling, naming

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2012-04-17.10:28:54.178>
created_at = <Date 2012-04-16.11:38:43.984>
labels = ['interpreter-core', 'performance']
title = 'PyErr_SetFromImportErrorWithNameAndPath lacks error checking'
updated_at = <Date 2012-04-17.10:28:54.177>
user = 'https://github.com/pitrou'

bugs.python.org fields:

activity = <Date 2012-04-17.10:28:54.177>
actor = 'pitrou'
assignee = 'none'
closed = True
closed_date = <Date 2012-04-17.10:28:54.178>
closer = 'pitrou'
components = ['Interpreter Core']
creation = <Date 2012-04-16.11:38:43.984>
creator = 'pitrou'
dependencies = []
files = []
hgrepos = []
issue_num = 14593
keywords = []
message_count = 1.0
messages = ['158411']
nosy_count = 4.0
nosy_names = ['brett.cannon', 'pitrou', 'brian.curtin', 'eric.snow']
pr_nums = []
priority = 'normal'
resolution = 'duplicate'
stage = 'needs patch'
status = 'closed'
superseder = '14600'
type = 'resource usage'
url = 'https://bugs.python.org/issue14593'
versions = ['Python 3.3']

[pitrou]

The PyErr_SetFromImportErrorWithNameAndPath implementation never checks for the various results returned by the C API functions it invokes.

(also, it needs documenting, see python-dev)

As for PyErr_SetExcWithArgsKwargs, there's a potential refleak when args is NULL.