Skipping a test mixin gives metaclass error

[pitrou]

BPO	14664
Nosy	@pitrou, @benjaminp, @voidspace
Files	skip_mixin.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2012-04-25.13:01:57.766>
created_at = <Date 2012-04-24.21:34:34.268>
labels = ['type-bug', 'library']
title = 'Skipping a test mixin gives metaclass error'
updated_at = <Date 2012-04-25.15:39:57.293>
user = 'https://github.com/pitrou'

bugs.python.org fields:

activity = <Date 2012-04-25.15:39:57.293>
actor = 'michael.foord'
assignee = 'none'
closed = True
closed_date = <Date 2012-04-25.13:01:57.766>
closer = 'pitrou'
components = ['Library (Lib)']
creation = <Date 2012-04-24.21:34:34.268>
creator = 'pitrou'
dependencies = []
files = ['25353']
hgrepos = []
issue_num = 14664
keywords = ['patch']
message_count = 8.0
messages = ['159213', '159216', '159277', '159278', '159285', '159300', '159301', '159303']
nosy_count = 4.0
nosy_names = ['pitrou', 'benjamin.peterson', 'michael.foord', 'python-dev']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue14664'
versions = ['Python 2.7', 'Python 3.2', 'Python 3.3']

[pitrou]

Seen on a buildbot:

test test_multiprocessing crashed -- Traceback (most recent call last):
  File "/export/home/buildbot/32bits/3.x.cea-indiana-x86/build/Lib/test/regrtest.py", line 1229, in runtest_inner
    the_package = __import__(abstest, globals(), locals(), [])
  File "<frozen importlib._bootstrap>", line 1030, in _find_and_load
  File "<frozen importlib._bootstrap>", line 611, in load_module
  File "<frozen importlib._bootstrap>", line 271, in module_for_loader_wrapper
  File "<frozen importlib._bootstrap>", line 499, in _load_module
  File "/export/home/buildbot/32bits/3.x.cea-indiana-x86/build/Lib/test/test_multiprocessing.py", line 2430, in <module>
    testcases_processes = create_test_cases(ProcessesMixin, type='processes')
  File "/export/home/buildbot/32bits/3.x.cea-indiana-x86/build/Lib/test/test_multiprocessing.py", line 2409, in create_test_cases
    class Temp(base, unittest.TestCase, Mixin):
TypeError: metaclass conflict: the metaclass of a derived class must be a (non-strict) subclass of the metaclasses of all its bases

Here is a patch.

[voidspace]

Patch looks good - thanks.

[python-dev]

New changeset ab3df6979bd0 by Antoine Pitrou in branch '3.2':
Issue bpo-14664: It is now possible to use @unittest.skip{If,Unless} on a test class that doesn't inherit from TestCase (i.e. a mixin).
http://hg.python.org/cpython/rev/ab3df6979bd0

New changeset 188b96e0ea89 by Antoine Pitrou in branch 'default':
Issue bpo-14664: It is now possible to use @unittest.skip{If,Unless} on a test class that doesn't inherit from TestCase (i.e. a mixin).
http://hg.python.org/cpython/rev/188b96e0ea89

[pitrou]

Fixed, thanks.

[voidspace]

This could go into 2.7 too.

[python-dev]

New changeset 8a8d2f05068a by Antoine Pitrou in branch '2.7':
Issue bpo-14664: It is now possible to use @unittest.skip{If,Unless} on a test class that doesn't inherit from TestCase (i.e. a mixin).
http://hg.python.org/cpython/rev/8a8d2f05068a

[pitrou]

This could go into 2.7 too.

Done!

[voidspace]

Thanks Antoine - much appreciated.