Add test to automatically detect missing format units in skipitem()

[larryhastings]

BPO	14769
Nosy	@larryhastings, @benjaminp
Files	larry.test_skipitem_parity.1.diff larry.test_skipitem_parity.2.diff larry.test_skipitem_parity.3.diff: Third patch larry.test_skipitem_parity.4.diff: Round four: fight!

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/larryhastings'
closed_at = <Date 2012-06-22.10:58:00.122>
created_at = <Date 2012-05-10.08:42:36.502>
labels = ['interpreter-core', 'type-feature']
title = 'Add test to automatically detect missing format units in skipitem()'
updated_at = <Date 2012-06-22.19:59:15.429>
user = 'https://github.com/larryhastings'

bugs.python.org fields:

activity = <Date 2012-06-22.19:59:15.429>
actor = 'python-dev'
assignee = 'larry'
closed = True
closed_date = <Date 2012-06-22.10:58:00.122>
closer = 'larry'
components = ['Interpreter Core']
creation = <Date 2012-05-10.08:42:36.502>
creator = 'larry'
dependencies = []
files = ['25515', '25840', '26060', '26064']
hgrepos = []
issue_num = 14769
keywords = ['patch']
message_count = 9.0
messages = ['160329', '160365', '162382', '163003', '163260', '163314', '163356', '163394', '163472']
nosy_count = 3.0
nosy_names = ['larry', 'benjamin.peterson', 'python-dev']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue14769'
versions = ['Python 3.3']

[larryhastings]

I recently fixed an old bug: some time ago someone added support for a new "format unit", 'Z', to PyArg_Parse(), but neglected to add matching support for it to skipitem(). Benjamin asked for a regression test. Initially I said, okay, how the hell do I test that? A quick grep showed that there was already a test like that, for the format unit 'C'. I figured adding another one-off test was dumb, and there had to be a better way.

Attached is a patch against trunk that adds a new function to _testcapimodule.c: test_skipitem_parity(). The comment at the top describes says it best:

• This function brute-force tests all** ASCII characters (1 to 127
• inclusive) as format units, checking to see that
• PyArg_ParseTupleAndKeywords() return consistent errors both when
• the unit is attempted to be used and when it is skipped. If the
• format unit doesn't exist, we'll get one of two specific error
• messages (one for used, one for skipped); if it does exist we
• *won't* get that error--we'll get either no error or some other
• error. If we get the "does not exist" error for one test and
• not for the other, there's a mismatch, and the test fails.
• ** Okay, it actually skips some ASCII characters. Some characters

•  have special funny semantics, and it would be difficult to
  

•  accomodate them here.
  

I also removed the old test just for 'C', as this test subsumes that one.

Right now, the test runs to completion without complaint. To test that it's really working, comment out an existing case statement in skipitem(). Or, add a new case statement, for a character that isn't otherwise supported (yet), to the top paragraph of case statements. Doing either of these will cause a failure.

... you happy now, Benjamin?

[benjaminp]

Can you see if you can write that test in Python? Perhaps simply providing a wrapper to cal PyArg_Parse with the arguments you want.

[larryhastings]

I guess the answer was "no".

Attached is a new diff as you suggest. It isn't really any shorter--in fact it's about 20% longer. Though I freely admit it is more written-in-Python-y.

The test currently passes. If you add support for a new format unit (like add "case '8':" above "case 'H':" in convertsimple()) without adding the corresponding case to simpleitem(), it fails. If you perform the same operation on simpleitem() but not to convertsimple(), it again fails. So I assert the test is working 100% correctly.

[larryhastings]

Ping. Benjamin, should I find another reviewer?

[larryhastings]

Changes incorporated from Benjamin's feedback. Thanks, Benjamin!

Is this ready to go?

[larryhastings]

Incorporates Benjamin's self-admitted pedantic changes ;-)

Will it survive? Will it get checked in? Tune in... soon, I hope!

[benjaminp]

Okay

[python-dev]

New changeset ace45d23628a by Larry Hastings in branch 'default':
Issue bpo-14769: test_capi now has SkipitemTest, which cleverly checks
http://hg.python.org/cpython/rev/ace45d23628a

[python-dev]

New changeset 40d7869501a2 by Larry Hastings in branch 'default':
Issue bpo-14769: Incorporated mildly pedantic feedback from python-dev.
http://hg.python.org/cpython/rev/40d7869501a2