PyObject_IsTrue failure checks

[serhiy-storchaka]

BPO	15604
Nosy	@jcea, @pitrou, @asvetlov, @serhiy-storchaka
Files	istrue_check-3.3.patch: Patch for 3.3 istrue_check-3.2.patch: Patch for 3.2 istrue_check-2.7.patch: Patch for 2.7 istrue_check-3.3_2.patch istrue_check-3.2_2.patch istrue_check-2.7_2.patch istrue_check-3.3_3.patch istrue_check-3.2_3.patch istrue_check-2.7_3.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2012-08-15.21:45:36.260>
created_at = <Date 2012-08-09.15:24:15.052>
labels = ['interpreter-core', 'library', 'performance']
title = 'PyObject_IsTrue failure checks'
updated_at = <Date 2012-08-16.01:07:16.630>
user = 'https://github.com/serhiy-storchaka'

bugs.python.org fields:

activity = <Date 2012-08-16.01:07:16.630>
actor = 'jcea'
assignee = 'none'
closed = True
closed_date = <Date 2012-08-15.21:45:36.260>
closer = 'serhiy.storchaka'
components = ['Interpreter Core', 'Library (Lib)']
creation = <Date 2012-08-09.15:24:15.052>
creator = 'serhiy.storchaka'
dependencies = []
files = ['26742', '26743', '26744', '26813', '26814', '26815', '26838', '26839', '26840']
hgrepos = []
issue_num = 15604
keywords = ['patch', 'needs review']
message_count = 7.0
messages = ['167789', '167794', '167906', '168243', '168337', '168339', '168341']
nosy_count = 5.0
nosy_names = ['jcea', 'pitrou', 'asvetlov', 'python-dev', 'serhiy.storchaka']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'resource usage'
url = 'https://bugs.python.org/issue15604'
versions = ['Python 2.7', 'Python 3.2', 'Python 3.3']

[serhiy-storchaka]

PyObject_IsTrue can fail, but not everywhere in a code a returned value checked. Here is a patches which add such checks.

Note, patches for all three Python versions are rather different.

[pitrou]

Is it possible to add test cases for (at least some of) these issues?

[serhiy-storchaka]

I shall try to do this, but it will take a lot of time. Besides, now in the code there are a lot of *correct* checked usage of PyObject_IsTrue without test cases. So I'm not sure that the tests are needed here, and that they are worth the effort.

[serhiy-storchaka]

Patches updated to reflect Antoine's comments.

[serhiy-storchaka]

Patches updated again.

[python-dev]

New changeset ba1c48f8b571 by Antoine Pitrou in branch '2.7':
Issue bpo-15604: Update uses of PyObject_IsTrue() to check for and handle errors correctly.
http://hg.python.org/cpython/rev/ba1c48f8b571

New changeset 56dc7b09f390 by Antoine Pitrou in branch '3.2':
Issue bpo-15604: Update uses of PyObject_IsTrue() to check for and handle errors correctly.
http://hg.python.org/cpython/rev/56dc7b09f390

New changeset b878df1d23b1 by Antoine Pitrou in branch 'default':
Issue bpo-15604: Update uses of PyObject_IsTrue() to check for and handle errors correctly.
http://hg.python.org/cpython/rev/b878df1d23b1

[serhiy-storchaka]

Thank you Antoine.