test_winsound bombing out on 2003 buildslave

[tpn]

BPO	15746
Nosy	@vstinner, @tpn

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/tpn'
closed_at = <Date 2012-10-27.02:23:55.825>
created_at = <Date 2012-08-21.02:17:31.300>
labels = ['type-bug']
title = 'test_winsound bombing out on 2003 buildslave'
updated_at = <Date 2012-10-27.02:23:55.824>
user = 'https://github.com/tpn'

bugs.python.org fields:

activity = <Date 2012-10-27.02:23:55.824>
actor = 'trent'
assignee = 'trent'
closed = True
closed_date = <Date 2012-10-27.02:23:55.825>
closer = 'trent'
components = []
creation = <Date 2012-08-21.02:17:31.300>
creator = 'trent'
dependencies = []
files = []
hgrepos = []
issue_num = 15746
keywords = []
message_count = 4.0
messages = ['168729', '168756', '168843', '173910']
nosy_count = 2.0
nosy_names = ['vstinner', 'trent']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue15746'
versions = ['Python 2.7']

[tpn]

The 'Windows Server 2003 R2 SP1' build slave I set up keeps bombing out on test_winsound:

======================================================================
FAIL: test_alias_nofallback (test.test_winsound.PlaySoundTest)
----------------------------------------------------------------------

Traceback (most recent call last):
  File "E:\Data\buildslave\cpython\2.7.snakebite-win2k3r2sp2-x86\build\lib\test\test_winsound.py", line 199, in test_alias_nofallback
    '!"$%&/(#+*', winsound.SND_ALIAS | winsound.SND_NODEFAULT
AssertionError: RuntimeError not raised

Raising this as a placeholder until I can look into it in more detail.

[vstinner]

Copy of the test:

    def test_alias_nofallback(self):
        if _have_soundcard():
            # Note that this is not the same as asserting RuntimeError
            # will get raised:  you cannot convert this to
            # self.assertRaises(...) form.  The attempt may or may not
            # raise RuntimeError, but it shouldn't raise anything other
            # than RuntimeError, and that's all we're trying to test
            # here.  The MS docs aren't clear about whether the SDK
            # PlaySound() with SND_ALIAS and SND_NODEFAULT will return
            # True or False when the alias is unknown.  On Tim's WinXP
            # box today, it returns True (no exception is raised).  What
            # we'd really like to test is that no sound is played, but
            # that requires first wiring an eardrum class into unittest
            # <wink>.
            try:
                winsound.PlaySound(
                    '!"$%&/(#+*',
                    winsound.SND_ALIAS | winsound.SND_NODEFAULT
                )
            except RuntimeError:
                pass
        else:
            self.assertRaises(           <~~~~ HERE
                RuntimeError,
                winsound.PlaySound,
                '!"$%&/(#+*', winsound.SND_ALIAS | winsound.SND_NODEFAULT
            )

So according to Lib/test/check_soundcard.vbs, the buildbot has no soundcard. Is this correct?

[tpn]

Affirmative:

E:\Apps\activestate-python-2.7.2.5-x86>python
ActivePython 2.7.2.5 (ActiveState Software Inc.) based on
Python 2.7.2 (default, Jun 24 2011, 12:21:10) [MSC v.1500 32 bit (Intel)] on win32
Type "help", "copyright", "credits" or "license" for more information.
>>> import test.test_winsound
>>> test.test_winsound._have_soundcard()
False
>>> import winsound
>>> winsound.PlaySound('!"$%&/(#+*', winsound.SND_ALIAS | winsound.SND_NODEFAULT)
>>>

No exception raised. (No sound is played, either, FWIW.)

I like the approach taken by the method before test_alias_nofallback():

    def test_alias_fallback(self):
        # This test can't be expected to work on all systems.  The MS
        # PlaySound() docs say:
        #
        #     If it cannot find the specified sound, PlaySound uses the
        #     default system event sound entry instead.  If the function
        #     can find neither the system default entry nor the default
        #     sound, it makes no sound and returns FALSE.
        #
        # It's known to return FALSE on some real systems.

        # winsound.PlaySound('!"$%&/(#+*', winsound.SND_ALIAS)
        return

I suspect that'll solve all our problems ;-)

[tpn]

We avoided this by adding -u-audio to the affected slave.