Fix bare excepts in various places in std lib

[RamchandraApte]

BPO	16261
Nosy	@brettcannon, @terryjreedy, @vstinner, @ezio-melotti, @merwok, @asvetlov, @vadmium, @serhiy-storchaka
Files	patch.patch bare_except.patch: Regenerated for Rietveld

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/serhiy-storchaka'
closed_at = <Date 2015-05-20.07:35:47.678>
created_at = <Date 2012-10-17.08:06:05.258>
labels = ['type-bug', 'library']
title = 'Fix bare excepts in various places in std lib'
updated_at = <Date 2015-05-20.07:35:47.677>
user = 'https://bugs.python.org/RamchandraApte'

bugs.python.org fields:

activity = <Date 2015-05-20.07:35:47.677>
actor = 'serhiy.storchaka'
assignee = 'serhiy.storchaka'
closed = True
closed_date = <Date 2015-05-20.07:35:47.678>
closer = 'serhiy.storchaka'
components = ['Library (Lib)']
creation = <Date 2012-10-17.08:06:05.258>
creator = 'Ramchandra Apte'
dependencies = []
files = ['28647', '28648']
hgrepos = []
issue_num = 16261
keywords = ['patch']
message_count = 20.0
messages = ['173140', '173175', '174264', '174403', '174406', '174452', '174489', '174564', '174565', '179441', '179442', '179445', '179448', '179449', '179456', '202448', '216810', '243639', '243650', '243651']
nosy_count = 11.0
nosy_names = ['brett.cannon', 'terry.reedy', 'vstinner', 'ezio.melotti', 'eric.araujo', 'asvetlov', 'python-dev', 'sbt', 'Ramchandra Apte', 'martin.panter', 'serhiy.storchaka']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue16261'
versions = ['Python 3.5']

[RamchandraApte]

Will attach patch.

[brettcannon]

One thing to be aware of, Ramchandra, is that there might be a slight backwards-compatibility problem from tightening up what exceptions propagate. Now with proper documentation and only applying things to 3.4 this probably won't be a problem.

[RamchandraApte]

This seems quite difficult for one person;there are 589 lines having "except:"
I'll work on the Tools directory.
If anybody wants to help, please tell which folder you will do.

[asvetlov]

I'm pretty sure Doc and Lib are already fixed, only Tools left.

[RamchandraApte]

On 1 November 2012 17:21, Andrew Svetlov <report@bugs.python.org> wrote:

Andrew Svetlov added the comment:

I'm pretty sure Doc and Lib are already fixed, only Tools left.

----------
nosy: +asvetlov

---

Python tracker <report@bugs.python.org>
<http://bugs.python.org/issue16261\>

---

No. 405 are there in Lib. Try running grep "except:" -R Lib --include "*.py" to see yourself.

[asvetlov]

Sorry, looks like I don't understood you correctly.
Do you want to replace `except:` to `except Exception` or something else?

[RamchandraApte]

Yes.
most of the bare excepts can be replaced with a stricter clause

On 2 November 2012 01:06, Andrew Svetlov <report@bugs.python.org> wrote:

Andrew Svetlov added the comment:

Sorry, looks like I don't understood you correctly.
Do you want to replace `except:` to `except Exception` or something else?

----------

---

Python tracker <report@bugs.python.org>
<http://bugs.python.org/issue16261\>

---

[python-dev]

New changeset b2bd62d1644f by Andrew Svetlov in branch 'default':
Issue bpo-16261: fix bare excepts in Doc/
http://hg.python.org/cpython/rev/b2bd62d1644f

[asvetlov]

I've fixed bare except: in docs.
Tomorrow we will have Python sprint in Kiev.
Maybe somebody will take a look on Lib.

[RamchandraApte]

Here's a patch on revision 75fe7f5fda9a (I did it on a trip without an internet connection)
There might be some mistakes of this type:
I incorrectly changed instances like this
try: something except: close file raise
to
try: something finally: close file
(the incorrect version closes the file always)

[RamchandraApte]

Sorry, I entered the wrong filename for the patch and so it didn't get attached. Now I have attached it.

[serhiy-storchaka]

Unhappy Rietveld hasn't recognize your patch. I have regenerated it.

[sbt]

try:
_MAXFD = os.sysconf("SC_OPEN_MAX")
-except:
+except ValueError:
_MAXFD = 256

os.sysconf() might raise OSError. I think ValueError is only raised if _SC_OPEN_MAX was undefined when the module was compiled.