Int tests enhancement and refactoring

[serhiy-storchaka]

BPO	16784
Nosy	@ezio-melotti, @cjerdonek, @serhiy-storchaka, @iritkatriel
Dependencies	bpo-16761: Fix int(base=X) bpo-16772: int() accepts float number base bpo-16790: provide ability to share tests between int and long tests bpo-16792: Mark small ints test as CPython-only bpo-16793: Get rid of deprecated assertEquals etc in tests

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/serhiy-storchaka'
closed_at = <Date 2020-11-22.18:23:33.680>
created_at = <Date 2012-12-26.10:33:21.198>
labels = ['type-feature', 'tests']
title = 'Int tests enhancement and refactoring'
updated_at = <Date 2020-11-22.18:23:33.679>
user = 'https://github.com/serhiy-storchaka'

bugs.python.org fields:

activity = <Date 2020-11-22.18:23:33.679>
actor = 'iritkatriel'
assignee = 'serhiy.storchaka'
closed = True
closed_date = <Date 2020-11-22.18:23:33.680>
closer = 'iritkatriel'
components = ['Tests']
creation = <Date 2012-12-26.10:33:21.198>
creator = 'serhiy.storchaka'
dependencies = ['16761', '16772', '16790', '16792', '16793']
files = []
hgrepos = []
issue_num = 16784
keywords = []
message_count = 9.0
messages = ['178197', '178203', '178273', '178276', '178277', '178435', '178441', '222103', '380480']
nosy_count = 4.0
nosy_names = ['ezio.melotti', 'chris.jerdonek', 'serhiy.storchaka', 'iritkatriel']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue16784'
versions = ['Python 2.7', 'Python 3.2', 'Python 3.3', 'Python 3.4']

[serhiy-storchaka]

Int tests should be synchronized between different Python versions. Tests for int and long should be synchronized in 2.7. Common code for int and long tests should be shared in 2.7. CPython tests (i.e. small int identity) should be extracted to separated methods. Tests should be resorted by tested feature. Deprecated assertEquals should be replaced to assertEqual. And may be more.

[cjerdonek]

Other things that should be done include porting the more comprehensive tests in a recent changeset from 2.7 to 3.x and refactoring the try-except of one of the tests as necessary (see the Rietveld comments of bpo-16761 for details on both).

The various issues in this comment and above should probably be broken into multiple patches.

[cjerdonek]

I created bpo-16790 to allow the sharing of tests between test_int and test_long in 2.7. I don't think bpo-16761 and bpo-16772 should be prerequisites to this issue though because both issues could benefit from bpo-16790 being committed first (since both issues may involve adding tests to test_int and test_long).

Also, I don't necessarily think that *all* tests should be shared between test_int and test_long because that refactoring may be too invasive, but certainly the new ones we are considering adding.

[serhiy-storchaka]

A large part of IntTestCases.test_basic() and LongTest.test_long() can be shared, as a number of smaller tests.

[cjerdonek]

Agreed. I just didn't want it to be a requirement of beginning shared tests in case anyone objects to refactoring existing tests in 2.7 -- as opposed to using it for the addition of new tests.

[cjerdonek]

Another task: backport the tests for current behavior added under bpo-16772 (e.g. test_int_base_limits() tests).

[cjerdonek]

Improvement of int/long tests should also be reflected in the Tests section of Misc/NEWS. An entry wasn't added in bpo-16045. For linking purposes, this issue number would probably be the best to use for such an entry.

[BreamoreBoy]

is there anything left to do here?

[iritkatriel]

It seems that all dependencies are complete, so if nobody will object I will close this too.