Integer overflow in sqlite module

[serhiy-storchaka]

BPO	17073
Nosy	@mdickinson, @serhiy-storchaka
Files	sqlite_int_overflow-2.7.patch sqlite_int_overflow-3.2.patch sqlite_int_overflow-3.3.patch sqlite_int_overflow_tests.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/serhiy-storchaka'
closed_at = <Date 2013-02-07.15:09:15.093>
created_at = <Date 2013-01-29.17:01:48.644>
labels = ['extension-modules', 'type-bug']
title = 'Integer overflow in sqlite module'
updated_at = <Date 2013-04-28.11:17:57.818>
user = 'https://github.com/serhiy-storchaka'

bugs.python.org fields:

activity = <Date 2013-04-28.11:17:57.818>
actor = 'python-dev'
assignee = 'serhiy.storchaka'
closed = True
closed_date = <Date 2013-02-07.15:09:15.093>
closer = 'serhiy.storchaka'
components = ['Extension Modules']
creation = <Date 2013-01-29.17:01:48.644>
creator = 'serhiy.storchaka'
dependencies = []
files = ['28893', '28894', '28895', '28965']
hgrepos = []
issue_num = 17073
keywords = ['patch']
message_count = 4.0
messages = ['180915', '181448', '181618', '187976']
nosy_count = 4.0
nosy_names = ['ghaering', 'mark.dickinson', 'python-dev', 'serhiy.storchaka']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue17073'
versions = ['Python 2.7', 'Python 3.2', 'Python 3.3', 'Python 3.4']

[serhiy-storchaka]

The proposed patch fixes an integer overflow in such cases:

1. When an authorizer callback (registered with set_authorizer()) returns an integer which doesn't fit into C int. Now integers out of C int range interpreted as SQLITE_DENY (as any non-integer values).

2. When a callable used in create_collation() returns an integer which doesn't fit into C int. Now all Python integers work.

3. When Python integer doesn't fit into SQLite INTEGER. Now overflow detected and an exception raised.

4. Now sqlite module built even when HAVE_LONG_LONG is not defined.

[serhiy-storchaka]

Here are tests for some bugs.

[python-dev]

New changeset 649937bb8f1c by Serhiy Storchaka in branch '2.7':
Issue bpo-17073: Fix some integer overflows in sqlite3 module.
http://hg.python.org/cpython/rev/649937bb8f1c

New changeset 55a89352e220 by Serhiy Storchaka in branch '3.2':
Issue bpo-17073: Fix some integer overflows in sqlite3 module.
http://hg.python.org/cpython/rev/55a89352e220

New changeset c5fb8bc56def by Serhiy Storchaka in branch '3.3':
Issue bpo-17073: Fix some integer overflows in sqlite3 module.
http://hg.python.org/cpython/rev/c5fb8bc56def

New changeset b8a6bc70fc08 by Serhiy Storchaka in branch 'default':
Issue bpo-17073: Fix some integer overflows in sqlite3 module.
http://hg.python.org/cpython/rev/b8a6bc70fc08

[python-dev]

New changeset 44fe1f5b07e3 by Serhiy Storchaka in branch '2.7':
Issue bpo-17857: Prevent build failures with pre-3.5.0 versions of sqlite3,
http://hg.python.org/cpython/rev/44fe1f5b07e3