IDLE: Always include "Options" menu on MacOSX

[serwy]

BPO	17532
Nosy	@ronaldoussoren, @ned-deily, @serwy, @rovitotv
Files	17532MenuOptions.patch 17532MenuOptions-1.patch 17532MenuOptions-2.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/ned-deily'
closed_at = <Date 2013-05-22.22:28:16.121>
created_at = <Date 2013-03-23.21:41:30.253>
labels = ['easy', 'expert-IDLE', 'type-bug']
title = 'IDLE: Always include "Options" menu on MacOSX'
updated_at = <Date 2013-07-20.22:08:59.426>
user = 'https://github.com/serwy'

bugs.python.org fields:

activity = <Date 2013-07-20.22:08:59.426>
actor = 'python-dev'
assignee = 'ned.deily'
closed = True
closed_date = <Date 2013-05-22.22:28:16.121>
closer = 'ned.deily'
components = ['IDLE']
creation = <Date 2013-03-23.21:41:30.253>
creator = 'roger.serwy'
dependencies = []
files = ['29893', '29899', '30000']
hgrepos = []
issue_num = 17532
keywords = ['patch', 'easy']
message_count = 13.0
messages = ['185098', '187126', '187147', '187220', '187222', '187227', '187619', '187622', '187685', '187688', '189838', '189839', '193421']
nosy_count = 6.0
nosy_names = ['ronaldoussoren', 'ned.deily', 'roger.serwy', 'Todd.Rovito', 'python-dev', 'Guilherme.Sim\xc3\xb5es']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue17532'
versions = ['Python 2.7', 'Python 3.3', 'Python 3.4']

[serwy]

Presently, the "Options" menu gets eliminated if IDLE runs as an OSX app. This behavior was introduced in 2006 in revision 654c380cf8b9.

I guess that the original motivation for eliminating the Options menu since it usually only contained the "Configure IDLE" option, and the Lib/idlelib/macosxSupport.py code supports using the Preferences menu item to open the configuration dialog. (The only other item would be the Code Context toggle.)

Extensions that rely on the Options menu being present will not function properly, especially when the menu item involves a queried boolean variable for its checkmark status.

[GuilhermeSimes]

I tested the extensions in MacOS and they seem to work (even the Terminal Mode). The Options menu appear and everything seems to be fine.

The patch attached removes the Configure entry from the Options menu because this entry is already in the application menu as "Preferences". It also includes the Options menu in editor windows even without extensions, allowing the use of Code Context.

[GuilhermeSimes]

I actually removed something I shouldn't have in the first patch so I'm attaching a new one.

[rovitotv]

I tested the patch on OS X 10.8 and it works perfect!!!

Thanks Guilherme.

[serwy]

Hi Guilherme,

Have you signed the contributor agreement? It can be found at: http://www.python.org/psf/contrib/contrib-form/

Your patch looks good to me, but I don't have a Mac to test against. I trust Todd's test that it works on the latest MacOSX version. Hopefully it works on earlier OSX versions as well. (I think it should, but Tk on Mac has been problematic.)

[GuilhermeSimes]

Hi Roger,

I just signed the contributor agreement. Unfortunately, I can't test on older MacOS versions, but I also think it should work.

[ned-deily]

Thanks for the patch, Guilherme. While the patch does restore the Options menu for Edit windows, a similar change is needed in idlelib/PyShell.py to also restore the menu for the shell window. I will refresh the patch or include it in the changes for bpo-17654 which will change how and where the menus are customized for OS X.

[GuilhermeSimes]

I didn't restore the menu in the shell window because it would be empty then. Perhaps a better alternative is to automatically remove any empty menu. That way if someone inserted a new option in the menu in the future it would show automatically in the MacOS version.

[serwy]

The Options menu will become populated as soon as other extensions get included into IDLE, such as bpo-6143.

[GuilhermeSimes]

Since extensions are probably going to be included into IDLE soon I'm attaching a version of the patch that also changes PyShell.py.

[python-dev]

New changeset e134714e3b30 by Ned Deily in branch '2.7':
Issue bpo-17532: Always include Options menu for IDLE on OS X.
http://hg.python.org/cpython/rev/e134714e3b30

New changeset 75c3e9a659bc by Ned Deily in branch '3.3':
Issue bpo-17532: Always include Options menu for IDLE on OS X.
http://hg.python.org/cpython/rev/75c3e9a659bc

New changeset d0a093f40801 by Ned Deily in branch 'default':
Issue bpo-17532: merge
http://hg.python.org/cpython/rev/d0a093f40801