socketmodule raises on import when compiled using Setup.dist on 2.7.4

[bkabrda]

BPO	17662
Nosy	@kristjanvalur
Files	python-2.7.4-properly-compile-socketmodule-by-Setupdist.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2013-04-08.16:04:41.193>
created_at = <Date 2013-04-08.12:57:16.924>
labels = ['build', 'type-crash']
title = 'socketmodule raises on import when compiled using Setup.dist on 2.7.4'
updated_at = <Date 2013-04-08.16:04:41.193>
user = 'https://bugs.python.org/bkabrda'

bugs.python.org fields:

activity = <Date 2013-04-08.16:04:41.193>
actor = 'kristjan.jonsson'
assignee = 'none'
closed = True
closed_date = <Date 2013-04-08.16:04:41.193>
closer = 'kristjan.jonsson'
components = ['Build']
creation = <Date 2013-04-08.12:57:16.924>
creator = 'bkabrda'
dependencies = []
files = ['29730']
hgrepos = []
issue_num = 17662
keywords = ['patch']
message_count = 3.0
messages = ['186298', '186309', '186315']
nosy_count = 3.0
nosy_names = ['kristjan.jonsson', 'python-dev', 'bkabrda']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = 'crash'
url = 'https://bugs.python.org/issue17662'
versions = ['Python 2.7']

[bkabrda]

When building extension modules of Python 2.7.4 through Modules/Setup.dist, the socketmodule gets built badly, as it also needs to be compiled with timemodule.c (see the attached patch).
This was caused by commit 8ec39bfd1f01, which introduced usage of _PyTime_floattime() without fixing Setup.dist (note, that this is ok when compiling through setup.py, as it has:

exts.append( Extension('_socket', ['socketmodule.c', 'timemodule.c'],

[kristjanvalur]

This is my fault,
I admit to not being an expert in non-windows builds.
I've no idea how Modules/Setup.dist works but the patch looks reasonable and if it works, then all is fine.

[python-dev]

New changeset bad85e4e6b7f by Kristjan Valur Jonsson in branch '2.7':
Issue bpo-17662: fix socketmodule compilation with Setup.dist.
http://hg.python.org/cpython/rev/bad85e4e6b7f