Save on Close windows (IDLE)

[GuilhermeSimes]

BPO	17822
Nosy	@terryjreedy, @serwy, @bitdancer, @rovitotv
Files	askyesnocancel.py inhibit_close.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/terryjreedy'
closed_at = <Date 2019-09-19.00:51:45.323>
created_at = <Date 2013-04-23.13:13:33.263>
labels = ['3.7', 'expert-IDLE', 'type-bug', 'expert-tkinter', 'OS-windows']
title = 'Save on Close windows (IDLE)'
updated_at = <Date 2019-09-19.00:51:45.320>
user = 'https://bugs.python.org/GuilhermeSimes'

bugs.python.org fields:

activity = <Date 2019-09-19.00:51:45.320>
actor = 'terry.reedy'
assignee = 'terry.reedy'
closed = True
closed_date = <Date 2019-09-19.00:51:45.323>
closer = 'terry.reedy'
components = ['IDLE', 'Tkinter', 'Windows']
creation = <Date 2013-04-23.13:13:33.263>
creator = 'Guilherme.Sim\xc3\xb5es'
dependencies = []
files = ['29992', '29997']
hgrepos = []
issue_num = 17822
keywords = ['patch']
message_count = 18.0
messages = ['187641', '187657', '187664', '187671', '187672', '187674', '187678', '187683', '187684', '188173', '220035', '220040', '220047', '220060', '220065', '220066', '220075', '352762']
nosy_count = 6.0
nosy_names = ['terry.reedy', 'gpolo', 'roger.serwy', 'r.david.murray', 'Todd.Rovito', 'Guilherme.Sim\xc3\xb5es']
pr_nums = []
priority = 'normal'
resolution = 'out of date'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue17822'
versions = ['Python 3.6', 'Python 3.7']

[GuilhermeSimes]

After changing the contents of a file in an Editor Window and closing without saving the "Save on Close" window pops up. On both MacOS and Linux the user can't do anything on the Editor Window anymore, but on Windows, not only can the user continue to write it is possible to try to close the window again. Each time the user attempts to close the editor the "Save on Close" window appears one more time.

Also, when you have 2 such windows if you say 'no' then,no matter what the answer to the second window is, IDLE crashes.

I'm not sure but this seems to me to be a Tk problem. Attached is a simple script that works completely different on different systems showing that this is probably a Tkinter or Tk bug.

I tested this on Mac with Python 2.7, 3.3, 3.4 and Tk 8.5.13. On Linux I tested with Python 3.2 and Tk 8.5.11 and on Windows with Python 3.3 and Tk 8.5.11.

[terryjreedy]

What behavior on which system to you consider to be buggy? On 3.3.1, Win 7, all seems fine. By selecting Windows as a component, you imply that something is wrong on Windows.

"on Windows, not only can the user continue to write[(if the user Cancels),] it is possible to try to close the window again. Each time the user attempts to close the editor the "Save on Close" window appears one more time."

This is what should happen.

"Also, when you have 2 such windows if you say 'no' then,no matter what the answer to the second window is, IDLE crashes."

I do not see this.

'with Python 3.3': 3.3 is a version of the language. 3.3.0 and 3.3.1 are two different patch releases. Did you use the latter, which has several Idle improvements? When discussing bugs, we need to be specific as to releases used.

[bitdancer]

Interesting that you consider Windows working as expected, Terry. I thought save/close dialogs were generally modal; but, then, I avoid GUIs whenever possible so I could easily be wrong :)

[terryjreedy]

Because model is normal (as far as I know) I did not understand that 'continue to write' meant doing so without hitting [Cancel] ;-). I might consider being able to do so a feature *if* the dialog were the only one ever created and if subsequent attempts to close merely shifted focus back to the dialog.

However, after shifting focus back to the edit window without hitting [Cancel] and hitting [X] again, I get a *duplicate* "Save on Close" dialog. This is a bug somewhere. I get this duplication on 2.7.4a1 and 3.4a0 also. Only the last dialog created works to close the window.

On 3.3, after closing the edit window with the last dialog [No], I can duplicate the unexpected Idle exit by selecting any of the 3 choices in the previous dialog. This is a second and more serious bug. I do not see this with 2.7.

When I run 3.3 Idle from the console interpreter with 'import idlelib.idle', the Shell window does not close, mimicking 2.7.
The console displays '''
Exception in Tkinter callback
Traceback (most recent call last):
  File "C:\Python33\lib\tkinter\__init__.py", line 1475, in __call__
    return self.func(*args)
  File "C:\Python33\lib\idlelib\EditorWindow.py", line 996, in close
    reply = self.maybesave()
  File "C:\Python33\lib\idlelib\EditorWindow.py", line 993, in maybesave
    return self.io.maybesave()
  File "C:\Python33\lib\idlelib\IOBinding.py", line 331, in maybesave
    self.text.focus_set()
AttributeError: 'NoneType' object has no attribute 'focus_set'
'''
Running 2.7 shows the same message. So this AttributeError seems not to be the exception causing Idle 3.3 to quit when run otherwise.

[terryjreedy]

If I open Command Prompt, and start Idle with
C:\Python\Python33>python -m idlelib
I get the same attribute error without the Shell window closing. Perhaps not having a console to write the traceback to closes 3.3 but not 2.7. Peculiar.

[terryjreedy]

A different console message, Shell window not closed

Python 3.4.0a0 (default:bcfb6888fb8d, Apr 18 2013, 19:47:33) 
>>> import idlelib.idle
Exception in Tkinter callback
Traceback (most recent call last):
  File "\cpython\lib\tkinter\__init__.py", line 1475, in __call__
    return self.func(*args)
  File "\cpython\lib\idlelib\EditorWindow.py", line 1002, in close
    reply = self.maybesave()
  File "\cpython\lib\idlelib\EditorWindow.py", line 999, in maybesa
ve
    return self.io.maybesave()
  File "\cpython\lib\idlelib\IOBinding.py", line 324, in maybesave
    self.save(None)
  File "\cpython\lib\idlelib\IOBinding.py", line 338, in save
    if self.writefile(self.filename):
  File "\cpython\lib\idlelib\IOBinding.py", line 370, in writefile
    self.fixlastline()
  File \cpython\lib\idlelib\IOBinding.py", line 426, in fixlastlin
e
    c = self.text.get("end-2c")
AttributeError: 'NoneType' object has no attribute 'get'

There is, of course, no 3.4 installation icon for starting Idle without a console. However
D:\Python\dev\cpython\PCbuild>pythonw_d -m idlelib

No message, Shell closes.

D:\Python\dev\cpython\PCbuild>python_d -m idlelib
...
AttributeError: 'NoneType' object has no attribute 'focus_set'

Message (different from other method of starting), Shell does not close.

[GuilhermeSimes]

From what I could see the problem is that in MacOS askyesnocancel stops the user from interacting with all windows and in Windows it stops the interaction only in the root window (even when the parameter 'master' is used, as is the case in IDLE). Since the root window in IDLE is hidden askyesnocancel doesn't do anything.

[serwy]

IDLE crashing is due to bpo-13582. We should maybe focus on that issue in the near future as it has become a common theme in many bug reports.

[serwy]

I clicked submit too soon. The attached patch inhibits closing of the Editor when the dialog box appears. It also sets the parent argument so that Tkinter on Windows actually presents a modal dialog box.

What's happening is the the dialog box enters a nested Tk eventloop which allows the editor window to be closed by the window manager via clicking "X". That re-enters the maybesave dialog. The first one unwinds and closes the editor window, setting its internal references to None. The initial maybesave resumes execution with the rug pulled out from beneath its feet and raises errors.