extra code in argparse.py

[aho]

BPO	17940
Nosy	@berkerpeksag
Files	issue17940.patch issue17940-27.patch: Patch for 2.7 branch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2016-03-05.12:06:40.417>
created_at = <Date 2013-05-08.22:32:30.810>
labels = ['type-feature', 'library']
title = 'extra code in argparse.py'
updated_at = <Date 2016-03-05.12:06:40.414>
user = 'https://bugs.python.org/aho'

bugs.python.org fields:

activity = <Date 2016-03-05.12:06:40.414>
actor = 'berker.peksag'
assignee = 'none'
closed = True
closed_date = <Date 2016-03-05.12:06:40.417>
closer = 'berker.peksag'
components = ['Library (Lib)']
creation = <Date 2013-05-08.22:32:30.810>
creator = 'aho'
dependencies = []
files = ['30214', '30215']
hgrepos = []
issue_num = 17940
keywords = ['patch']
message_count = 8.0
messages = ['188742', '188902', '188903', '188904', '188985', '189084', '261213', '261214']
nosy_count = 7.0
nosy_names = ['bethard', 'tshepang', 'python-dev', 'berker.peksag', 'paul.j3', 'Yogesh.Chaudhari', 'aho']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue17940'
versions = ['Python 3.6']

[aho]

In class HelpFormatter, class _Section, format_help(self)
(lines 199 & 200), the two lines

            for func, args in self.items:
                func(*args)

aren't necessary; the results of func are ignored.
"func" is applied (again) on the next line when the
output is joined into item_help.

Cheers
.a

[YogeshChaudhari]

Removed the duplicated code from argparse.py

[YogeshChaudhari]

Remove extra code in argparse.py for 2.7 branch

[YogeshChaudhari]

I have added a patch for default branch as well, because IMO the same issue exists in all branches

[YogeshChaudhari]

I guess that was simple enough. I am new to this issue tracker for Cpython. How will the patch review/commit proceed?

[paulj3]

I was wondering about that block of code earlier.

It would be a good idea to look at what func() does, just to make sure there aren't any side effects - e.g. set maximum line length, required indention, etc.

[python-dev]

New changeset be3874cf87f3 by Berker Peksag in branch 'default':
Issue bpo-17940: Remove redundant code from _Section.format_help()
https://hg.python.org/cpython/rev/be3874cf87f3

[berkerpeksag]

Thanks!