IDLE on OS X fails with Attribute Error if no initial shell and Tk out-of-date

[dbackhaus]

BPO	18270
Nosy	@terryjreedy, @kbkaiser, @amauryfa, @ned-deily, @serwy
Files	18270-27.diff 18270-27-B.diff: Fewer changes, should fix issue.

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/ned-deily'
closed_at = <Date 2013-12-11.00:56:56.777>
created_at = <Date 2013-06-20.14:40:02.960>
labels = ['expert-IDLE']
title = 'IDLE on OS X fails with Attribute Error if no initial shell and Tk out-of-date'
updated_at = <Date 2013-12-11.00:56:56.775>
user = 'https://bugs.python.org/dbackhaus'

bugs.python.org fields:

activity = <Date 2013-12-11.00:56:56.775>
actor = 'ned.deily'
assignee = 'ned.deily'
closed = True
closed_date = <Date 2013-12-11.00:56:56.777>
closer = 'ned.deily'
components = ['IDLE']
creation = <Date 2013-06-20.14:40:02.960>
creator = 'dbackhaus'
dependencies = []
files = ['31135', '31136']
hgrepos = []
issue_num = 18270
keywords = ['patch']
message_count = 9.0
messages = ['191518', '191523', '191539', '191544', '194229', '194235', '194237', '205873', '205874']
nosy_count = 7.0
nosy_names = ['terry.reedy', 'kbk', 'amaury.forgeotdarc', 'ned.deily', 'roger.serwy', 'python-dev', 'dbackhaus']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue18270'
versions = ['Python 2.7', 'Python 3.3', 'Python 3.4']

[dbackhaus]

It just worked fine yesterday, but when I start IDLE (with and without trying to open a file at the same time) I get this error.

 Traceback (most recent call last):
  File "/Library/Frameworks/Python.framework/Versions/2.7/bin/idle", line 5, in <module>
    main()
  File "/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/idlelib/PyShell.py", line 1560, in main
    shell.interp.runcommand(''.join(("print('", tkversionwarning, "')")))
AttributeError: 'NoneType' object has no attribute 'interp'

[amauryfa]

PyShell.py, line 1541:
if shell and cmd or script:
Does it need parentheses?
if shell and (cmd or script):

[ned-deily]

The problem here occurs when IDLE on OS X is launched without an initial shell window, either by setting the option in IDLE preferences or from the command line (/usr/local/bin/idle -e) *and* IDLE detects that the version of Tk in use is one of the suspect OS X versions and is attempting to warn the user with this message in the shell window:

WARNING: The version of Tcl/Tk (8.5.9) in use may be unstable.
Visit http://www.python.org/download/mac/tcltk/ for current information.

Unfortunately, that doesn't work if there is no shell window.

The workaround is to follow the instructions at the above link and, if possible, install an up-to-date Tcl/Tk 8.5 from ActiveState. If that is not possible, then launch IDLE from the command line with an initial shell window:

/usr/local/bin/idle2.7 -i

and be sure to change the preference to always launch with a shell window.

[terryjreedy]

In 2.7.5, the offending line is 1558, not 1560. It is clearer to me as
shell.interp.runcommand("print('%s')" % tkversionwarning)

Amaury is correct about 1541, as seen in the if block itself, but I thing the shell test should be elevated to guard all the shell-dependend actions, not just this one. See below.

To me, the problem in the cracked code and convoluted code is this:

If enable_shell (1520), call open_shell to set both flist.shell and shell but return if shell is None. But then at 1532, shell is set to flist.shell, and that can only have effect if not enable_shell (as otherwise shell *is* flist.shell due to return if None). In this case I expect flist.shell will always be None (its backup default as 292). But anyway, 1532 should be at least become an else: block for 1520.

The following lines up to 1558 all depend on shell not being None, but only one block is guarded. So I think they should all be guarded with one 'if shell:' and 'shell removed from 1541

2.7 patch attached. 3.3 code looks identical in this area, so it should have same problem and patch should apply to that also.

[ned-deily]

Terry, your patch did not get attached. Do you still have it?

[terryjreedy]

No, but I recreated it from my description and attached it. But see next message.

[terryjreedy]

Looking further at handling debug, startup, cmd, or script options. When any of these are set, enable_shell is also, so to reach here, shell must be true, so only the MAC test, the subject of this issue, needs protection. Smaller patch (fewer lines changed) attached.

---
Not part of this issue, but if someone can explain ...:
This this bit under "if cmd or script:" puzzles me.
shell.interp.runcommand("""if 1:
import sys as _sys
_sys.argv = %r
del _sys
\n""" % (sys.argv,))
Since the only lasting effect it can have is on the already imported sys module, it seems to be equivalent to
sys.argv = "%r" % (sys.argv)
And I do not know what net effect that has, if anything.

[python-dev]

New changeset 5becf8b612ee by Ned Deily in branch '2.7':
Issue bpo-18270: Prevent possible IDLE AttributeError on OS X when no initial
http://hg.python.org/cpython/rev/5becf8b612ee

New changeset 016c64e66a9e by Ned Deily in branch '3.3':
Issue bpo-18270: Prevent possible IDLE AttributeError on OS X when no initial
http://hg.python.org/cpython/rev/016c64e66a9e

New changeset 9d1fb265b88a by Ned Deily in branch 'default':
Issue bpo-18270: merge from 3.3
http://hg.python.org/cpython/rev/9d1fb265b88a

[ned-deily]

Thanks for the patch, Terry. I've pushed a slightly modified version for release in 2.7.7, 3.3.4, and 3.4.0.