make profile-opt fails with pre-existing python2.7 in path

[ClaudioFreire]

BPO	18493
Nosy	@zware

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2020-04-27.04:16:49.274>
created_at = <Date 2013-07-18.17:47:37.918>
labels = ['type-bug', 'build']
title = 'make profile-opt fails with pre-existing python2.7 in path'
updated_at = <Date 2020-04-27.04:16:49.273>
user = 'https://bugs.python.org/ClaudioFreire'

bugs.python.org fields:

activity = <Date 2020-04-27.04:16:49.273>
actor = 'zach.ware'
assignee = 'none'
closed = True
closed_date = <Date 2020-04-27.04:16:49.274>
closer = 'zach.ware'
components = ['Build']
creation = <Date 2013-07-18.17:47:37.918>
creator = 'Claudio.Freire'
dependencies = []
files = []
hgrepos = []
issue_num = 18493
keywords = []
message_count = 3.0
messages = ['193313', '228609', '367387']
nosy_count = 2.0
nosy_names = ['zach.ware', 'Claudio.Freire']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue18493'
versions = ['Python 2.7', 'Python 3.4', 'Python 3.5']

[ClaudioFreire]

When building with --enable-shared in an environment that already has a python2.7 (and I'd expect the same to happen to 3.x), make profile-opt fails because it attempts to load the existing libpython instead of the just-built one.

run_profile_task should use RUNSHARED. In fact, it builds fine if $(RUNSHARED) is added to that line.

Patch inline below, for 2.7.5:

--- Makefile.pre.in.bk  2013-07-18 17:46:28.671773378 +0000
+++ Makefile.pre.in     2013-07-18 17:46:47.759806100 +0000
@@ -420,7 +420,7 @@
 
 run_profile_task:
        : # FIXME: can't run for a cross build
-       ./$(BUILDPYTHON) $(PROFILE_TASK)
+       $(RUNSHARED) ./$(BUILDPYTHON) $(PROFILE_TASK)
 
 build_all_use_profile:
        $(MAKE) all CFLAGS="$(CFLAGS) -fprofile-use"

[BreamoreBoy]

Can somebody please take a look at the inline patch in msg193313.

[zware]

This was fixed in 3.x in 2015 and later backported to 2.7 in 2017. Thanks for the report, Claudio, and I'm sorry nobody noticed this earlier or we could have fixed the issue two years earlier!