-
-
Notifications
You must be signed in to change notification settings - Fork 31.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename and document test.bytecode_helper as test.support.bytecode_helper #62778
Comments
test.bytecode_helper provides various utilities for sensibly testing bytecode generation. It isn't easy for CPython developers to discover, since it isn't documented and the file is mixed in with actual tests in the main test directory. As discussed in bpo-15494, it should be:
This change only affects the default branch (since test.bytecode_helper is new in 3.4) |
I am working on a patch. |
I have a hard time figuring out what exactly BytecodeTestCase methods actually do. Thus the documentation is not probably accurate. |
@seydou, would you be interested in making a GitHub pull request for your patch? |
I wanted to merge the PR of Joannah but I have a question, are you sure that there is nobody using this module. Maybe we could add a warning when a user tries to use the module/function with a DeprecationWarning. Could we have a wrapper raising the warning when we call it and redirect to the new function? Thank you |
Other discussion with Zach, and at the end, there is no problem to merge your PR. Thank you for your contribution |
Just noting for the record that the reason a new warning wasn't needed here is because there is already a general "No compatibility guarantees" warning for the entire test package: https://docs.python.org/3/library/test.html Thanks for getting this resolved! |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
bugs.python.org fields:
The text was updated successfully, but these errors were encountered: