time.strptime exception context

[PCManticore]

BPO	19545
Nosy	@abalkin, @ezio-melotti, @PCManticore, @serhiy-storchaka
Files	time_strptime.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/serhiy-storchaka'
closed_at = <Date 2013-11-24.16:19:48.110>
created_at = <Date 2013-11-10.17:03:45.120>
labels = ['type-bug', 'library']
title = 'time.strptime exception context'
updated_at = <Date 2013-11-24.16:19:48.109>
user = 'https://github.com/PCManticore'

bugs.python.org fields:

activity = <Date 2013-11-24.16:19:48.109>
actor = 'serhiy.storchaka'
assignee = 'serhiy.storchaka'
closed = True
closed_date = <Date 2013-11-24.16:19:48.110>
closer = 'serhiy.storchaka'
components = ['Library (Lib)']
creation = <Date 2013-11-10.17:03:45.120>
creator = 'Claudiu.Popa'
dependencies = []
files = ['32563']
hgrepos = []
issue_num = 19545
keywords = ['patch']
message_count = 4.0
messages = ['202536', '204226', '204228', '204229']
nosy_count = 5.0
nosy_names = ['belopolsky', 'ezio.melotti', 'Claudiu.Popa', 'python-dev', 'serhiy.storchaka']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue19545'
versions = ['Python 3.4']

[PCManticore]

time.strptime leaks an IndexError, as seen in the following traceback.

[root@clnstor /tank/libs/cpython]# ./python
Python 3.4.0a4+ (default:0aa2aedc6a21+, Nov  5 2013, 17:10:42)
[GCC 4.2.1 20070831 patched [FreeBSD]] on freebsd8
Type "help", "copyright", "credits" or "license" for more information.
>>> import time
>>> time.strptime('19', '%Y %')
Traceback (most recent call last):
  File "/tank/libs/cpython/Lib/_strptime.py", line 320, in _strptime
    format_regex = _TimeRE_cache.compile(format)
  File "/tank/libs/cpython/Lib/_strptime.py", line 268, in compile
    return re_compile(self.pattern(format), IGNORECASE)
  File "/tank/libs/cpython/Lib/_strptime.py", line 262, in pattern
    self[format[directive_index]])
IndexError: string index out of range

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/tank/libs/cpython/Lib/_strptime.py", line 494, in _strptime_time
    tt = _strptime(data_string, format)[0]
  File "/tank/libs/cpython/Lib/_strptime.py", line 332, in _strptime
    raise ValueError("stray %% in format '%s'" % format)
ValueError: stray % in format '%Y %'
>>>

The attached patch suppresses the exception. This issue is similar (and based on) the bpo-17572.

[serhiy-storchaka]

LGTM.

[python-dev]

New changeset ce1578f4d105 by Serhiy Storchaka in branch '3.3':
Issue bpo-19545: Avoid chained exceptions while passing stray % to
http://hg.python.org/cpython/rev/ce1578f4d105

New changeset 2bf4741515a7 by Serhiy Storchaka in branch 'default':
Issue bpo-19545: Avoid chained exceptions while passing stray % to
http://hg.python.org/cpython/rev/2bf4741515a7

[serhiy-storchaka]

Thank you for your contribution.