test_read_pty_output() hangs on FreeBSD 7.2 buildbot

[vstinner]

BPO	20495
Nosy	@gvanrossum, @vstinner, @skrah
Files	skip_read_pty_freebsd72.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2014-02-11.17:42:50.716>
created_at = <Date 2014-02-03.01:29:28.234>
labels = []
title = 'test_read_pty_output() hangs on FreeBSD 7.2 buildbot'
updated_at = <Date 2014-03-17.06:30:54.128>
user = 'https://github.com/vstinner'

bugs.python.org fields:

activity = <Date 2014-03-17.06:30:54.128>
actor = 'python-dev'
assignee = 'none'
closed = True
closed_date = <Date 2014-02-11.17:42:50.716>
closer = 'vstinner'
components = []
creation = <Date 2014-02-03.01:29:28.234>
creator = 'vstinner'
dependencies = []
files = ['34043']
hgrepos = []
issue_num = 20495
keywords = ['patch']
message_count = 6.0
messages = ['210072', '210074', '210968', '210977', '210987', '213811']
nosy_count = 4.0
nosy_names = ['gvanrossum', 'vstinner', 'skrah', 'python-dev']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue20495'
versions = ['Python 3.4']

[vstinner]

http://buildbot.python.org/all/builders/x86%20FreeBSD%207.2%203.x/builds/4969/steps/test/logs/stdio
---
[298/389/1] test_asyncio
Timeout (1:00:00)!
Current thread 0x28401040 (most recent call first):
File "/usr/home/db3l/buildarea/3.x.bolen-freebsd7/build/Lib/asyncio/base_events.py", line 208 in time
File "/usr/home/db3l/buildarea/3.x.bolen-freebsd7/build/Lib/asyncio/base_events.py", line 641 in _run_once
File "/usr/home/db3l/buildarea/3.x.bolen-freebsd7/build/Lib/asyncio/base_events.py", line 154 in run_forever
File "/usr/home/db3l/buildarea/3.x.bolen-freebsd7/build/Lib/asyncio/base_events.py", line 173 in run_until_complete
File "/usr/home/db3l/buildarea/3.x.bolen-freebsd7/build/Lib/asyncio/test_utils.py", line 44 in run_briefly
File "/usr/home/db3l/buildarea/3.x.bolen-freebsd7/build/Lib/asyncio/test_utils.py", line 59 in run_until
File "/usr/home/db3l/buildarea/3.x.bolen-freebsd7/build/Lib/test/test_asyncio/test_events.py", line 979 in test_read_pty_output
...
---

FYI The test is now skipped on Mac OS X older than 10.6, the test on the kqueue selector is skipped on Mac OS X older than 10.9: issue bpo-20472.

[gvanrossum]

I guess this is not a total surprise given that OS X derives in some way from BSD...

I wonder if we just need to make a matrix of which OS versions and which syscalls can handle PTYs correctly, and either put it in the docs or perhaps even refuse to accept PTYs in add_reader/add_writer...

[vstinner]

I wonder if we just need to make a matrix of which OS versions and which syscalls can handle PTYs correctly, and either put it in the docs or perhaps even refuse to accept PTYs in add_reader/add_writer...

Right now, I think that we don't have enough data to decide on which OS and OS versions such error should be raised. But I agree that it would be nice to raise an error instead of hang, crash, or just behave badly.

Until that, here is a patch to skip the test on FreeBSD < 8.0.

The test hangs on FreeBSD 7.2, test_asyncio pass on FreeBSD 9. The FreeBSD 8 buildbot is offline. test_asyncio is skipped on FreeBSD 6.4.

[gvanrossum]

LGTM

[python-dev]

New changeset 2ba583191550 by Victor Stinner in branch 'default':
Issue bpo-20495: Skip test_read_pty_output() of test_asyncio on FreeBSD older than
http://hg.python.org/cpython/rev/2ba583191550

[python-dev]

New changeset 2cf25865fc66 by Victor Stinner in branch '3.4':
Issue bpo-20495: Skip test_read_pty_output() of test_asyncio on FreeBSD older than
http://hg.python.org/cpython/rev/2cf25865fc66