don't defined socket constants which are not implemented for GNU/Hurd

[doko42]

BPO	21273
Nosy	@doko42, @pitrou, @benjaminp
Files	hurd-disable-nonworking-constants.diff

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2014-04-28.22:40:56.642>
created_at = <Date 2014-04-16.22:30:07.552>
labels = ['extension-modules']
title = "don't defined socket constants which are not implemented for GNU/Hurd"
updated_at = <Date 2014-04-28.22:40:56.641>
user = 'https://github.com/doko42'

bugs.python.org fields:

activity = <Date 2014-04-28.22:40:56.641>
actor = 'pitrou'
assignee = 'none'
closed = True
closed_date = <Date 2014-04-28.22:40:56.642>
closer = 'pitrou'
components = ['Extension Modules']
creation = <Date 2014-04-16.22:30:07.552>
creator = 'doko'
dependencies = []
files = ['34932']
hgrepos = []
issue_num = 21273
keywords = ['patch']
message_count = 4.0
messages = ['216610', '216691', '216693', '217434']
nosy_count = 3.0
nosy_names = ['doko', 'pitrou', 'benjamin.peterson']
pr_nums = []
priority = 'normal'
resolution = 'rejected'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue21273'
versions = ['Python 3.4', 'Python 3.5']

[doko42]

Comment out constant exposed on the API which are not implemented on
GNU/Hurd. They would not work at runtime anyway.

[benjaminp]

I'm not sure this is a good idea. In general, we expose whatever libc defines, and let it give ENOSYS (or similar) errors if the underlying system doesn't actually support the behavior. Presumably, the Hurd might implement SO_REUSEPORT at some point.

[pitrou]

Indeed, this complicates the conditional defines for no obvious benefit.

[pitrou]

Ok, rejecting.