PyBuffer_ToContiguous() off-by-one error for non-contiguous buffers

[rhansen]

BPO	23349
Nosy	@skrah
Files	PyBuffer_ToContiguous.patch: patch that fixes this bug issue23349-2.diff

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2015-01-31.14:26:07.054>
created_at = <Date 2015-01-30.01:07:08.624>
labels = ['interpreter-core', 'type-bug']
title = 'PyBuffer_ToContiguous() off-by-one error for non-contiguous buffers'
updated_at = <Date 2015-01-31.14:26:07.053>
user = 'https://bugs.python.org/rhansen'

bugs.python.org fields:

activity = <Date 2015-01-31.14:26:07.053>
actor = 'skrah'
assignee = 'none'
closed = True
closed_date = <Date 2015-01-31.14:26:07.054>
closer = 'skrah'
components = ['Interpreter Core']
creation = <Date 2015-01-30.01:07:08.624>
creator = 'rhansen'
dependencies = []
files = ['37912', '37927']
hgrepos = []
issue_num = 23349
keywords = ['patch']
message_count = 4.0
messages = ['235011', '235042', '235048', '235109']
nosy_count = 3.0
nosy_names = ['skrah', 'rhansen', 'python-dev']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue23349'
versions = ['Python 2.7']

[rhansen]

PyBuffer_ToContiguous() has an off-by-one error when copying a buffer it thinks is non-contiguous.

To reproduce, put the following in foo.pyx and compile with Cython v0.21.2:

cpdef foo():
    cdef unsigned char[:] v = bytearray("testing")
    print repr(memoryview(v).tobytes())

>>> import foo
>>> foo.foo()
'estingt'

(This issue was fixed for Python 3.x in issue bpo-12834 but it was not fixed for Python 2.7.)

[skrah]

Looks good, here's a patch with tests.

[python-dev]

New changeset a9305102c892 by Stefan Krah in branch '2.7':
Issue bpo-23349: Fix off-by-one error in PyBuffer_ToContiguous(). Initial patch
https://hg.python.org/cpython/rev/a9305102c892

[skrah]

Should be fixed, thanks for the patch.