Stop using deprecated imp module; imp should now emit a real DeprecationWarning

[vstinner]

BPO	25160
Nosy	@brettcannon, @ncoghlan, @vstinner, @ambv, @ericsnowcurrently, @berkerpeksag, @JelleZijlstra, @isidentical
PRs	bpo-35936: Updates to modulefinder #11787 bpo-35936: Updates to modulefinder #11787
Files	issue25160-2to3.patch: patch for lib2to3

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2020-06-05.18:36:26.036>
created_at = <Date 2015-09-18.07:06:19.691>
labels = ['3.8', 'type-feature', 'library']
title = 'Stop using deprecated imp module; imp should now emit a real DeprecationWarning'
updated_at = <Date 2020-06-05.18:36:26.035>
user = 'https://github.com/vstinner'

bugs.python.org fields:

activity = <Date 2020-06-05.18:36:26.035>
actor = 'brett.cannon'
assignee = 'none'
closed = True
closed_date = <Date 2020-06-05.18:36:26.036>
closer = 'brett.cannon'
components = ['Library (Lib)']
creation = <Date 2015-09-18.07:06:19.691>
creator = 'vstinner'
dependencies = []
files = ['43113']
hgrepos = []
issue_num = 25160
keywords = ['patch']
message_count = 15.0
messages = ['250946', '250948', '250949', '250950', '262467', '266914', '266929', '266931', '339564', '339565', '357975', '358127', '358194', '358196', '370778']
nosy_count = 10.0
nosy_names = ['brett.cannon', 'ncoghlan', 'vstinner', 'Arfrever', 'lukasz.langa', 'python-dev', 'eric.snow', 'berker.peksag', 'JelleZijlstra', 'BTaskaya']
pr_nums = ['11787', '11787']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue25160'
versions = ['Python 3.8']

[vstinner]

The imp module is deprecated since Python 3.4. In Python 3.4, imp uses a PendingDeprecationWarning, and Python 3.5... hum, still a PendingDeprecationWarning. It was not supposed to become a real DeprecationWarning?

Anyway, the imp module is still used in some places of the Python stdlib:

Lib/modulefinder.py:14: import imp
Python/makeopcodetargets.py:9:import imp
Tools/i18n/pygettext.py:159:import imp
Tools/importbench/importbench.py:10:import imp

modulefinder explicitly ignore the warning :-(

with warnings.catch_warnings():
    warnings.simplefilter('ignore', PendingDeprecationWarning)
    import imp

[berkerpeksag]

Python/makeopcodetargets.py:9:import imp

See bpo-20021.

[python-dev]

New changeset 03cd8340e0ce by Victor Stinner in branch '3.5':
Issue bpo-25160: Fix import_init() comments and messages
https://hg.python.org/cpython/rev/03cd8340e0ce

[berkerpeksag]

Lib/modulefinder.py:14: import imp

I forgot to link bpo-20020 in my earlier message :)

[vstinner]

Tools/i18n/pygettext.py:159:import imp

I opened the issue bpo-26639 for it.

> Python/makeopcodetargets.py:9:import imp
See bpo-20021.

I pushed the change f682b620c64d but I forgot about the issue bpo-20021. Let's discuss there about this script.

Tools/importbench/importbench.py:10:import imp

I think that it's fine to keep imp there.

Lib/modulefinder.py:14: import imp

This one requires more work than the other.

[JelleZijlstra]

Current status:

• 2to3 replaces reload() calls with imp.reload
• Lib/modulefinder.py imports imp and uses it 10 or so times, mostly for constants
• Lib/xml/sax/init.py uses imp on Jython only
• Python/makeopcodetargets.py falls back to imp if importlib is not available.
• Tools/importbench/importbench.py uses imp a number of times.

I'll work on replacing some of these.

[JelleZijlstra]

One more:

• lib/pkgutil.py in _import_imp (amusingly) uses importlib with silenced warnings to import imp.

[berkerpeksag]

• 2to3 replaces reload() calls with imp.reload

There is an already open issue for this: bpo-21446.

[ncoghlan]

Fixed for Python 3.8 via the patch for bpo-35936.

[ncoghlan]

Oops, this covers more than just modulefinder - reopening until the other remaining uses of the imp module have been removed.