EOFError in test_nntplib.NetworkedNNTPTests.test_starttls()

[vadmium]

BPO	25859
Nosy	@berkerpeksag, @vadmium
Files	starttls_server.py starttls-server.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2016-01-19.03:19:14.318>
created_at = <Date 2015-12-14.09:00:26.784>
labels = ['type-bug', 'tests']
title = 'EOFError in test_nntplib.NetworkedNNTPTests.test_starttls()'
updated_at = <Date 2016-01-19.03:19:14.317>
user = 'https://github.com/vadmium'

bugs.python.org fields:

activity = <Date 2016-01-19.03:19:14.317>
actor = 'martin.panter'
assignee = 'none'
closed = True
closed_date = <Date 2016-01-19.03:19:14.318>
closer = 'martin.panter'
components = ['Tests']
creation = <Date 2015-12-14.09:00:26.784>
creator = 'martin.panter'
dependencies = []
files = ['41303', '41327']
hgrepos = []
issue_num = 25859
keywords = ['patch', 'buildbot']
message_count = 4.0
messages = ['256374', '256468', '256504', '258566']
nosy_count = 3.0
nosy_names = ['python-dev', 'berker.peksag', 'martin.panter']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue25859'
versions = ['Python 3.5', 'Python 3.6']

[vadmium]

The AMD64 Debian root buildbot and the x86 Gentoo Installed with X buildbot have been persistently failing test_nntplib for a while, and I can also reproduce it locally when “test -unetwork” is enabled. Six test cases fail. There is a pause before test_starttls() fails, then all the others fail immediately:

test_newgroups (test.test_nntplib.NetworkedNNTPTests) ... ok
test_over (test.test_nntplib.NetworkedNNTPTests) ... ok
test_starttls (test.test_nntplib.NetworkedNNTPTests) ... ERROR
test_unknown_command (test.test_nntplib.NetworkedNNTPTests) ... ERROR
test_welcome (test.test_nntplib.NetworkedNNTPTests) ... ok
test_with_statement (test.test_nntplib.NetworkedNNTPTests) ... ok
test_xhdr (test.test_nntplib.NetworkedNNTPTests) ... ERROR
test_xover (test.test_nntplib.NetworkedNNTPTests) ... ERROR
test_zlogin (test.test_nntplib.NetworkedNNTPTests) ... ERROR
test_zzquit (test.test_nntplib.NetworkedNNTPTests) ... ERROR
test_article_head_body (test.test_nntplib.NetworkedNNTP_SSLTests) ... ok
test_capabilities (test.test_nntplib.NetworkedNNTP_SSLTests) ... ok

Traceback from first failure:

======================================================================
ERROR: test_starttls (test.test_nntplib.NetworkedNNTPTests)
----------------------------------------------------------------------

Traceback (most recent call last):
  File "/media/disk/home/proj/python/cpython/Lib/test/test_nntplib.py", line 252, in wrapped
    meth(self)
  File "/media/disk/home/proj/python/cpython/Lib/test/test_nntplib.py", line 210, in test_starttls
    self.server.starttls()
  File "/media/disk/home/proj/python/cpython/Lib/nntplib.py", line 1014, in starttls
    self.getcapabilities()
  File "/media/disk/home/proj/python/cpython/Lib/nntplib.py", line 390, in getcapabilities
    resp, caps = self.capabilities()
  File "/media/disk/home/proj/python/cpython/Lib/nntplib.py", line 558, in capabilities
    resp, lines = self._longcmdstring("CAPABILITIES")
  File "/media/disk/home/proj/python/cpython/Lib/nntplib.py", line 525, in _longcmdstring
    resp, list = self._getlongresp(file)
  File "/media/disk/home/proj/python/cpython/Lib/nntplib.py", line 476, in _getlongresp
    resp = self._getresp()
  File "/media/disk/home/proj/python/cpython/Lib/nntplib.py", line 449, in _getresp
    resp = self._getline()
  File "/media/disk/home/proj/python/cpython/Lib/nntplib.py", line 437, in _getline
    if not line: raise EOFError
EOFError

It seems like as soon as the TLS connection is successfully set up, the server (news.trigofacile.com) shuts down the connection.

Would it be appropriate to change this test so that instead of connecting to a remote server, we connect to a local server running in a background thread? I attach a Python script that runs a minimal server with hardcoded responses allowing test_starttls() to pass. Perhaps we could use this for test_starttls(). Maybe even extend it to other remote server tests as well.

[berkerpeksag]

Would it be appropriate to change this test so that instead of connecting to a remote server, we connect to a local server running in a background thread?

+1. We can host it at pythontest.net if needed. The repo is here: https://hg.python.org/pythontestdotnet/

[vadmium]

I don’t think there is much advantage hosting it on pythontest, but thanks for letting me know of the possibility. Here is a patch which runs it in a background localhost thread.

[python-dev]

New changeset a9fca95f119a by Martin Panter in branch '3.5':
Issue bpo-25859: Reimplement NNTP test_starttls() using local server
https://hg.python.org/cpython/rev/a9fca95f119a

New changeset c44bfa733526 by Martin Panter in branch 'default':
Issue bpo-25859: Merge NNTP test server from 3.5
https://hg.python.org/cpython/rev/c44bfa733526