cross building extensions picks up host headers

[hundeboll]

BPO	26443
Nosy	@doko42, @moreati
Superseder	bpo-20211: setup.py: do not add system header locations when cross compiling
Files	include-dirs.patch: remove addition of host dirs to include dirs when building extensions

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2016-03-09.15:11:29.684>
created_at = <Date 2016-02-26.15:19:33.885>
labels = ['build']
title = 'cross building extensions picks up host headers'
updated_at = <Date 2016-03-09.15:22:33.045>
user = 'https://bugs.python.org/hundeboll'

bugs.python.org fields:

activity = <Date 2016-03-09.15:22:33.045>
actor = 'berker.peksag'
assignee = 'none'
closed = True
closed_date = <Date 2016-03-09.15:11:29.684>
closer = 'hundeboll'
components = ['Cross-Build']
creation = <Date 2016-02-26.15:19:33.885>
creator = 'hundeboll'
dependencies = []
files = ['42032']
hgrepos = []
issue_num = 26443
keywords = ['patch']
message_count = 3.0
messages = ['260894', '261094', '261434']
nosy_count = 3.0
nosy_names = ['doko', 'Alex.Willmer', 'hundeboll']
pr_nums = []
priority = 'normal'
resolution = 'duplicate'
stage = 'resolved'
status = 'closed'
superseder = '20211'
type = 'compile error'
url = 'https://bugs.python.org/issue26443'
versions = ['Python 2.7', 'Python 3.5']

[hundeboll]

When cross building python, the building of extensions is called with -I/usr/include and -L/usr/lib

This makes some extensions fail to compile due to picking up inline assembly from host headers (e.g. _socket[1]).

I have fixed this locally by applying the attached patch, but I cannot tell if that would make other builds fail.

[1] log output:
building '_socket' extension
arm-cortexa9neon-linux-gnueabi-gcc -fPIC -Wno-unused-result -Wsign-compare -Wunreachable-code -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -I/home/mnhu/projects/pil/oe/tmp/work/machine/arm-cortexa9neon-linux-gnueabi/python-3.5.1/stage/machine/usr/lib/libffi-3.2.1/include -O2 -fexpensive-optimizations -fomit-frame-pointer -frename-registers -Werror=declaration-after-statement -I./Include -I/usr/include -I. -IInclude -I/home/mnhu/projects/pil/oe/tmp/work/machine/arm-cortexa9neon-linux-gnueabi/python-3.5.1/stage/cross/bin/../arm-cortexa9neon-linux-gnueabi/sysroot/usr/include -I/home/mnhu/projects/pil/oe/tmp/work/machine/arm-cortexa9neon-linux-gnueabi/python-3.5.1/src/Python-3.5.1/Include -I/home/mnhu/projects/pil/oe/tmp/work/machine/arm-cortexa9neon-linux-gnueabi/python-3.5.1/src/Python-3.5.1 -c /home/mnhu/projects/pil/oe/tmp/work/machine/arm-cortexa9neon-linux-gnueabi/python-3.5.1/src/Python-3.5.1/Modules/socketmodule.c -o build/temp.linux-arm-3.5/home/mnhu/projects/pil/oe/tmp/work/machine/arm-cortexa9neon-linux-gnueabi/python-3.5.1/src/Python-3.5.1/Modules/socketmodule.o
In file included from /usr/include/bits/byteswap.h:35:0,
from /usr/include/endian.h:60,
from /usr/include/bits/string2.h:51,
from /usr/include/string.h:635,
from ./Include/Python.h:30,
from /home/mnhu/projects/pil/oe/tmp/work/machine/arm-cortexa9neon-linux-gnueabi/python-3.5.1/src/Python-3.5.1/Modules/socketmodule.c:95:
/home/mnhu/projects/pil/oe/tmp/work/machine/arm-cortexa9neon-linux-gnueabi/python-3.5.1/src/Python-3.5.1/Modules/socketmodule.c: In function 'socket_getservbyport':
/usr/include/bits/byteswap-16.h:31:5: error: invalid 'asm': invalid operand for code 'w'
__asm__ ("rorw $8, %w0" \
^
/usr/include/netinet/in.h:403:21: note: in expansion of macro '__bswap_16'
# define htons(x) __bswap_16 (x)
^
/home/mnhu/projects/pil/oe/tmp/work/machine/arm-cortexa9neon-linux-gnueabi/python-3.5.1/src/Python-3.5.1/Modules/socketmodule.c:4861:24: note: in expansion of macro 'htons'
sp = getservbyport(htons((short)port), proto);
^

[moreati]

This looks like a duplicate of bpo-20211, and IMO the patch there is more correct.

[hundeboll]

Yes, it is a duplicate of bpo-20211, and I agree with the fix proposed in there.

Thanks for pointing it out.